Bug 40878 – Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Satish Sampath]

This is the first in a series of patches to enable speech in HTML input elements. I used http://trac.webkit.org/changeset/60543 as template for adding new conditionally compiled functionality and tested on my local machine to work.

More information about the speech input API proposal can be found in the following links:
 Parent bug: https://bugs.webkit.org/show_bug.cgi?id=39485
 Full API proposal: https://docs.google.com/View?id=dcfg79pz_5dhnp23f5
 Relevant discussions in the WHATWG list:
  - http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2010-May/026338.html
  - http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2010-June/026747.html

[Satish Sampath]

Created attachment 59185 [details]
Patch

[Kent Tamura]

Comment on attachment 59185 [details]
Patch

* You need to update WebKit2/Configurations/FeatureDefine.xcconfig.

WebKit/chromium/features.gypi:56
 +          'ENABLE_INPUT_SPEECH=0',
Please enable by default in order that buildbots can check compilation.
Enabling INPUT_SPEECH here doesn't mean Chromium/Chrome browser have INPUT_SPEECH.

[Satish Sampath]

Created attachment 59189 [details]
Patch

Added to Webkit2 config & enabled flag in chromium port

[Kent Tamura]

Comment on attachment 59189 [details]
Patch

LGTM.  Other reviewers, any comments?

[Jeremy Orlow]

Comment on attachment 59189 [details]
Patch

Seems fine to me.  r+ing

[WebKit Commit Bot]

Comment on attachment 59189 [details]
Patch

Rejecting patch 59189 from commit-queue.

Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
Last 500 characters of output:
es/win/tools/vsprops/FeatureDefinesCairo.vsprops
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/build-webkit
	M	configure.ac
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following ChangeLog files contain OOPS:

        trunk/WebCore/ChangeLog

    Please don't ever say "OOPS" in a ChangeLog file.
 at /usr/local/git/libexec/git-core/git-svn line 570


Full output: http://webkit-commit-queue.appspot.com/results/3284500

[Satish Sampath]

Created attachment 59254 [details]
Patch

Removed duplicate OOPS in changelog

[Steve Block]

Comment on attachment 59254 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 59254 [details]
Patch

Clearing flags on attachment: 59254

Committed r61545: <http://trac.webkit.org/changeset/61545>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.