RESOLVED FIXED Bug 40869
Change some WebPluginDabase ivars to use WebCore::String instead of NSString. 
https://bugs.webkit.org/show_bug.cgi?id=40869
Summary Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
Anders Carlsson
Reported 2010-06-18 17:28:25 PDT
Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
Attachments
Patch (10.24 KB, patch)
2010-06-18 17:29 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (12.70 KB, patch)
2010-06-20 13:18 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-06-18 17:29:31 PDT
Created attachment 59171 [details] Patch
Sam Weinig
Comment 2 2010-06-18 17:32:07 PDT
Comment on attachment 59171 [details] Patch r=me
Anders Carlsson
Comment 3 2010-06-18 17:35:22 PDT
Committed r61459: <http://trac.webkit.org/changeset/61459>
Adam Barth
Comment 4 2010-06-18 20:19:45 PDT
Might this have caused these tests to start timing out on Tiger? dom/html/level2/html/AppletsCollection.html plugins/qt-qwidget-plugin.html
Adam Barth
Comment 5 2010-06-18 20:26:04 PDT
Hum... It's 8:30 on a Friday and I don't see you on IRC. I'm going to try rolling this out to see if it fixes the problem.
Adam Barth
Comment 6 2010-06-18 20:36:08 PDT
Rolled out in http://trac.webkit.org/changeset/61464
Adam Barth
Comment 7 2010-06-18 20:36:32 PDT
Comment on attachment 59171 [details] Patch Clearing Sam's r+
WebKit Review Bot
Comment 8 2010-06-18 21:12:25 PDT
http://trac.webkit.org/changeset/61464 might have broken SnowLeopard Intel Release (Tests)
WebKit Review Bot
Comment 9 2010-06-18 22:27:31 PDT
http://trac.webkit.org/changeset/61459 might have broken Leopard Intel Debug (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/61458 http://trac.webkit.org/changeset/61459
Anders Carlsson
Comment 10 2010-06-20 13:18:03 PDT
Created attachment 59212 [details] Patch
Anders Carlsson
Comment 11 2010-06-20 13:28:10 PDT
Committed r61509: <http://trac.webkit.org/changeset/61509>
Note You need to log in before you can comment on or make changes to this bug.