Bug 40867 - Make WebCoreSystemInterface.h a C++ only header
Summary: Make WebCoreSystemInterface.h a C++ only header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-18 16:08 PDT by Anders Carlsson
Modified: 2010-06-18 20:21 PDT (History)
5 users (show)

See Also:


Attachments
Patch (32.14 KB, patch)
2010-06-18 16:10 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-06-18 16:08:45 PDT
Make WebCoreSystemInterface.h a C++ only header
Comment 1 Anders Carlsson 2010-06-18 16:10:52 PDT
Created attachment 59168 [details]
Patch
Comment 2 Anders Carlsson 2010-06-18 16:24:03 PDT
Committed r61453: <http://trac.webkit.org/changeset/61453>
Comment 3 Alexey Proskuryakov 2010-06-18 16:40:11 PDT
>Make WebCoreSystemInterface.h a C++ only header

Why?
Comment 4 WebKit Review Bot 2010-06-18 16:43:42 PDT
http://trac.webkit.org/changeset/61453 might have broken Chromium Mac Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/61452
http://trac.webkit.org/changeset/61453
Comment 5 Dimitri Glazkov (Google) 2010-06-18 17:21:46 PDT
(In reply to comment #4)
> http://trac.webkit.org/changeset/61453 might have broken Chromium Mac Release
> The following changes are on the blame list:
> http://trac.webkit.org/changeset/61452
> http://trac.webkit.org/changeset/61453

I tried fixing in http://trac.webkit.org/changeset/61455, but that wasn't the right fix. Can you please take a look at what's wrong?
Comment 6 Dimitri Glazkov (Google) 2010-06-18 20:21:05 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > http://trac.webkit.org/changeset/61453 might have broken Chromium Mac Release
> > The following changes are on the blame list:
> > http://trac.webkit.org/changeset/61452
> > http://trac.webkit.org/changeset/61453
> 
> I tried fixing in http://trac.webkit.org/changeset/61455, but that wasn't the right fix. Can you please take a look at what's wrong?

I fixed it! :) http://trac.webkit.org/changeset/61462.