RESOLVED FIXED Bug 40867
Make WebCoreSystemInterface.h a C++ only header 
https://bugs.webkit.org/show_bug.cgi?id=40867
Summary Make WebCoreSystemInterface.h a C++ only header
Anders Carlsson
Reported 2010-06-18 16:08:45 PDT
Make WebCoreSystemInterface.h a C++ only header
Attachments
Patch (32.14 KB, patch)
2010-06-18 16:10 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-06-18 16:10:52 PDT
Created attachment 59168 [details] Patch
Anders Carlsson
Comment 2 2010-06-18 16:24:03 PDT
Committed r61453: <http://trac.webkit.org/changeset/61453>
Alexey Proskuryakov
Comment 3 2010-06-18 16:40:11 PDT
>Make WebCoreSystemInterface.h a C++ only header Why?
WebKit Review Bot
Comment 4 2010-06-18 16:43:42 PDT
http://trac.webkit.org/changeset/61453 might have broken Chromium Mac Release The following changes are on the blame list: http://trac.webkit.org/changeset/61452 http://trac.webkit.org/changeset/61453
Dimitri Glazkov (Google)
Comment 5 2010-06-18 17:21:46 PDT
(In reply to comment #4) > http://trac.webkit.org/changeset/61453 might have broken Chromium Mac Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/61452 > http://trac.webkit.org/changeset/61453 I tried fixing in http://trac.webkit.org/changeset/61455, but that wasn't the right fix. Can you please take a look at what's wrong?
Dimitri Glazkov (Google)
Comment 6 2010-06-18 20:21:05 PDT
(In reply to comment #5) > (In reply to comment #4) > > http://trac.webkit.org/changeset/61453 might have broken Chromium Mac Release > > The following changes are on the blame list: > > http://trac.webkit.org/changeset/61452 > > http://trac.webkit.org/changeset/61453 > > I tried fixing in http://trac.webkit.org/changeset/61455, but that wasn't the right fix. Can you please take a look at what's wrong? I fixed it! :) http://trac.webkit.org/changeset/61462.
Note You need to log in before you can comment on or make changes to this bug.