Bug 4086 – fast_malloc should work on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Justin Haygood]

fast_malloc should work on Windows. Patch to do so attached to this.

[Justin Haygood]

Created attachment 3033 [details]
Fixes fast_malloc for Windows

Fixes fast_malloc for Windows.

[Justin Haygood]

Comment on attachment 3033 [details]
Fixes fast_malloc for Windows

Fixes fast_malloc for Windows

[Maciej Stachowiak]

Comment on attachment 3033 [details]
Fixes fast_malloc for Windows

A couple of comments:

+#if WIN32
+#include <assert.h>
+#endif

Seems like it would be better to include assert.h unconditionally, if it is
truly needed.

The extra conditional declaration of malloc_init_state seems wrong - wouldn't
the definition of __STD_C fall into the proper code path already?

+static void *sbrk (int size){
+
+    return sbrk((long)size);
+}

Why is this required? Any call passing an int should call through just fine to
the version that takes a long.

+#ifdef WIN32
+#define NDEBUG
+#endif

It's incorrect to define NDEBUG unconditionally on Windows. This should be
based on whether the build is debug or release.

Please addresse these comments and submit a new patch.