Bug 40848 – [Chromium] Show scrollbar steppers on Linux

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Platform

[xiyuan]

Per http://crbug.com/18303, user wants scrollbar steppers on Linux.

[xiyuan]

Created attachment 59257 [details]
Proposed patch.

The attached patch draws the steppers(aka arrows) using the colors in renderer prefs. It's still not ideal but as least user would have something to use.

Talked to webkit gardeners and this change needs manually landing because a bunch of image-based layout tests need rebaseline. So no commit queue.

[WebKit Review Bot]

Attachment 59257 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:46:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:47:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:48:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:49:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:51:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:52:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:53:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:177:  thumb_hsv is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:180:  track_hsv is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:200:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 11 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[xiyuan]

Created attachment 59260 [details]
Fix code style.

[Tony Chang]

Adding some Linux people (not sure what markus' bugzilla account is).

xiyuan, can you post a screen shot of what this looks like with a few different GTK+ themes?  Also, it's possible for GTK+ themes to position the arrows like on a mac (arrows on the bottom of the scrollbar).  Should we try to support that?  It looks like clearlooks can also do 3 arrows (win style + mac style):
http://www.fr3nd.net/wp-content/uploads/2006/08/clearlooks-next-sshot1.png

[Evan Stade]

see also <https://bugs.webkit.org/show_bug.cgi?id=35775>. I didn't really intend to let that patch die, but I moved on to other things and have been delinquent in getting back to it.

As long as we are adding the steppers, we should fix http://code.google.com/p/chromium/issues/detail?id=36919 as well (due to the difficulty of layout tests).

[Kent Tamura]

Comment on attachment 59260 [details]
Fix code style.

WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:86
 +        drawHorizLine(canvas, rect.x(), right, rect.y(), paint);
Indentatio is incorrect.


WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:88
 +        drawVertLine(canvas, right, rect.y(), bottom, paint);
ditto.


WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:90
 +        drawHorizLine(canvas, rect.x(), right, bottom, paint);
ditto.


WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:92
 +        drawVertLine(canvas, rect.x(), rect.y(), bottom, paint);
ditto.


I also think a screenshot is helpful.

[xiyuan]

tony: unfortunately, this naive simple fix does not take care of all possible steppers. That is, it only shows one up arrow at the beginning of the scrollbar and one down arrow at the end.

estade: I think your patch <https://bugs.webkit.org/show_bug.cgi?id=35775> is a way better fix than this. Any chance that you could get it in anytime soon?

will still post screenshots in case anyone is curious. :)

[xiyuan]

Created attachment 59389 [details]
screenshots for a few gtk themes (human, crux, mist, hight-contrast)

[Evan Stade]

xiyuan: sure, I can try to get it in this week.

[xiyuan]

Thanks, Evan.

*** This bug has been marked as a duplicate of bug 35775 ***