Bug 40844 - [v8] Web Inspector: don't add ScriptDebugServer as v8 listener if remote debugging is on
Summary: [v8] Web Inspector: don't add ScriptDebugServer as v8 listener if remote debu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-18 10:01 PDT by Yury Semikhatsky
Modified: 2010-06-20 23:44 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.09 KB, patch)
2010-06-18 10:05 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-06-18 10:01:40 PDT
[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if remote debugging is on
Comment 1 Yury Semikhatsky 2010-06-18 10:05:07 PDT
Created attachment 59128 [details]
Patch
Comment 2 Pavel Feldman 2010-06-19 03:21:34 PDT
Comment on attachment 59128 [details]
Patch

WebCore/bindings/v8/ScriptDebugServer.cpp:314
 +      return m_enabled;
If you get front-end accidentally opened, you will still be able to set the listener from within the front-end code, right?
Comment 3 Yury Semikhatsky 2010-06-20 22:42:35 PDT
(In reply to comment #2)
> (From update of attachment 59128 [details])
> WebCore/bindings/v8/ScriptDebugServer.cpp:314
>  +      return m_enabled;
> If you get front-end accidentally opened, you will still be able to set the listener from within the front-end code, right?

Correct.
Comment 4 Yury Semikhatsky 2010-06-20 23:44:33 PDT
Comment on attachment 59128 [details]
Patch

Clearing flags on attachment: 59128

Committed r61529: <http://trac.webkit.org/changeset/61529>
Comment 5 Yury Semikhatsky 2010-06-20 23:44:42 PDT
All reviewed patches have been landed.  Closing bug.