WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 40844
[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if remote debugging is on
https://bugs.webkit.org/show_bug.cgi?id=40844
Summary
[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if remote debu...
Yury Semikhatsky
Reported
2010-06-18 10:01:40 PDT
[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if remote debugging is on
Attachments
Patch
(4.09 KB, patch)
2010-06-18 10:05 PDT
,
Yury Semikhatsky
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1
2010-06-18 10:05:07 PDT
Created
attachment 59128
[details]
Patch
Pavel Feldman
Comment 2
2010-06-19 03:21:34 PDT
Comment on
attachment 59128
[details]
Patch WebCore/bindings/v8/ScriptDebugServer.cpp:314 + return m_enabled; If you get front-end accidentally opened, you will still be able to set the listener from within the front-end code, right?
Yury Semikhatsky
Comment 3
2010-06-20 22:42:35 PDT
(In reply to
comment #2
)
> (From update of
attachment 59128
[details]
) > WebCore/bindings/v8/ScriptDebugServer.cpp:314 > + return m_enabled; > If you get front-end accidentally opened, you will still be able to set the listener from within the front-end code, right?
Correct.
Yury Semikhatsky
Comment 4
2010-06-20 23:44:33 PDT
Comment on
attachment 59128
[details]
Patch Clearing flags on attachment: 59128 Committed
r61529
: <
http://trac.webkit.org/changeset/61529
>
Yury Semikhatsky
Comment 5
2010-06-20 23:44:42 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug