I have attached a manual test case that reproduces the problem on my page as well as a proposed fix. The timing is not correct either, but I will submit that as a separate bug once I determine what is going on there.
Created attachment 59122 [details] Proposed patch (with testcase)
Created attachment 59123 [details] Test case tar'd up.
Ah, that explains a few things I was seeing :) Good patch.
Created attachment 59438 [details] Rediff against trunk
Sam, why the patch does not include the test?
Comment on attachment 59438 [details] Rediff against trunk WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:634 + else if (!m_state.drawsContent && m_layer->drawsContent()) Is this an important differencial? WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:1194 + virtual AnimatedPropertyID getAnimatedProperty() const = 0; We normally do not use get. Maybe just call it animatedProperty()
Are there plans to update this patch?
(In reply to comment #6) > (From update of attachment 59438 [details]) > WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:634 > + else if (!m_state.drawsContent && m_layer->drawsContent()) > Is this an important differencial? > For the duration of this function, yes. It sync's the two at the end of the function but this conditional just notices that the state has changed and what action to take. > WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:1194 > + virtual AnimatedPropertyID getAnimatedProperty() const = 0; > We normally do not use get. Maybe just call it animatedProperty() Fair enough, will rename.
Created attachment 71509 [details] Patch
Sam, this looks like a good patch - would you like it committed or are you waiting for another patch?
Comment on attachment 71509 [details] Patch Rejecting patch 71509 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: ests/websocket/tests/workers ...... http/tests/workers ..... http/tests/xhtmlmp . http/tests/xmlhttprequest ........................................................................................................................................................................... http/tests/xmlhttprequest/web-apps ............... http/tests/xmlhttprequest/workers ......... 547.40s total testing time 21631 test cases (99%) succeeded 1 test case (<1%) was new 11 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4615058
Comment on attachment 71509 [details] Patch An updated patch is needed which includes -expected.txt files.
*** Bug 59198 has been marked as a duplicate of this bug. ***
I'll generate the missing -expected.txt and land this.
Committed r86680: <http://trac.webkit.org/changeset/86680>
Revision r86680 cherry-picked into qtwebkit-2.2 with commit 4495597 <http://gitorious.org/webkit/qtwebkit/commit/4495597>