Bug 40840 - [Qt] Symbian builds in release sometimes try to link with the debug JavaScriptCore static lib.
: [Qt] Symbian builds in release sometimes try to link with the debug JavaScrip...
Status: CLOSED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: S60 Hardware Other
: P2 Normal
Assigned To:
:
: Qt, QtTriaged
:
: 35784
  Show dependency treegraph
 
Reported: 2010-06-18 09:07 PST by
Modified: 2010-06-21 07:21 PST (History)


Attachments
Patch (1.79 KB, patch)
2010-06-18 09:18 PST, Jocelyn Turcotte
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-06-18 09:07:28 PST
Sbsv2 sometimes have problems with debug/release configuration determination causing QtWebKit in release to link with the debug JavaScriptCore static library.
------- Comment #1 From 2010-06-18 09:18:54 PST -------
Created an attachment (id=59120) [details]
Patch

I made that patch a while ago and I don't know if it would fix the problem or is still needed.

Janne, would you have any thought?
------- Comment #2 From 2010-06-18 14:30:47 PST -------
(From update of attachment 59120 [details])
I recall we spoke about this a while ago. I think the patch is fine. Feel free to set cq+ when you'd like to land it.
------- Comment #3 From 2010-06-21 01:45:35 PST -------
(From update of attachment 59120 [details])
Rejecting patch 59120 from commit-queue.

jocelyn.turcotte@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact eseidel@chromium.org to request a commit-queue restart.  After restart the commit-queue will correctly respect your committer rights.
------- Comment #4 From 2010-06-21 02:41:33 PST -------
(From update of attachment 59120 [details])
Committed as http://trac.webkit.org/changeset/61536.
------- Comment #5 From 2010-06-21 07:18:05 PST -------
<Cherry-pick-for-backport: r61536>
------- Comment #6 From 2010-06-21 07:20:27 PST -------
Revision r61536 cherry-picked into qtwebkit-2.0 with commit 98552a8cecd7b7c5c292727d81875ba0534a1a6f