WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
CLOSED FIXED
40840
[Qt] Symbian builds in release sometimes try to link with the debug JavaScriptCore static lib.
https://bugs.webkit.org/show_bug.cgi?id=40840
Summary
[Qt] Symbian builds in release sometimes try to link with the debug JavaScrip...
Jocelyn Turcotte
Reported
2010-06-18 09:07:28 PDT
Sbsv2 sometimes have problems with debug/release configuration determination causing QtWebKit in release to link with the debug JavaScriptCore static library.
Attachments
Patch
(1.79 KB, patch)
2010-06-18 09:18 PDT
,
Jocelyn Turcotte
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1
2010-06-18 09:18:54 PDT
Created
attachment 59120
[details]
Patch I made that patch a while ago and I don't know if it would fix the problem or is still needed. Janne, would you have any thought?
Simon Hausmann
Comment 2
2010-06-18 14:30:47 PDT
Comment on
attachment 59120
[details]
Patch I recall we spoke about this a while ago. I think the patch is fine. Feel free to set cq+ when you'd like to land it.
WebKit Commit Bot
Comment 3
2010-06-21 01:45:35 PDT
Comment on
attachment 59120
[details]
Patch Rejecting patch 59120 from commit-queue.
jocelyn.turcotte@nokia.com
does not have committer permissions according to
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py
. - If you do not have committer rights please read
http://webkit.org/coding/contributing.html
for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to
bug 30084
the commit-queue will require a restart after your change. Please contact
eseidel@chromium.org
to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights.
Jocelyn Turcotte
Comment 4
2010-06-21 02:41:33 PDT
Comment on
attachment 59120
[details]
Patch Committed as
http://trac.webkit.org/changeset/61536
.
Simon Hausmann
Comment 5
2010-06-21 07:18:05 PDT
<Cherry-pick-for-backport:
r61536
>
Simon Hausmann
Comment 6
2010-06-21 07:20:27 PDT
Revision
r61536
cherry-picked into qtwebkit-2.0 with commit 98552a8cecd7b7c5c292727d81875ba0534a1a6f
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug