After switching to ScriptDebugServer, DebuggerAgent protocol can no more be used.
Created attachment 59111 [details] proposed patch
Attachment 59111 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/bindings/v8/ScriptProfiler.cpp:55: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 59114 [details] lint
Comment on attachment 59114 [details] lint WebCore/bindings/js/ScriptProfiler.h:42 + static void heapSnapshot() { } Please rename it for consistency with other code to takeHeapSnapshot. WebCore/bindings/v8/ScriptProfiler.h:46 + static void heapSnapshot(); Please make sure there is a bug about heap snapshotting in JSC.
(In reply to comment #4) > (From update of attachment 59114 [details]) > WebCore/bindings/js/ScriptProfiler.h:42 > + static void heapSnapshot() { } > Please rename it for consistency with other code to takeHeapSnapshot. > Renamed. > WebCore/bindings/v8/ScriptProfiler.h:46 > + static void heapSnapshot(); > Please make sure there is a bug about heap snapshotting in JSC. There is https://bugs.webkit.org/show_bug.cgi?id=31134 requesting heap snapshotting.
Manually committed http://trac.webkit.org/changeset/61411 2010-06-18 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. WebInspector: Implement 'takeHeapSnapshot' in InspectorController. https://bugs.webkit.org/show_bug.cgi?id=40834 * bindings/js/ScriptProfiler.h: (WebCore::ScriptProfiler::takeHeapSnapshot): * bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::takeHeapSnapshot): * bindings/v8/ScriptProfiler.h: * inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::takeHeapSnapshot): * inspector/InspectorBackend.h: * inspector/InspectorBackend.idl: * inspector/InspectorController.cpp: (WebCore::InspectorController::takeHeapSnapshot): * inspector/InspectorController.h: * src/js/HeapProfilerPanel.js: (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked): * src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl): * src/js/ProfilerAgent.js: (devtools.ProfilerAgent.prototype.startProfiling):