Bug 40791 - Warnings from -Wextra in a Chromium Mac build
Summary: Warnings from -Wextra in a Chromium Mac build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-17 10:59 PDT by Thomas Van Lenten
Modified: 2010-06-19 07:07 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch for the warnings (6.78 KB, patch)
2010-06-17 11:11 PDT, Thomas Van Lenten
dglazkov: review-
dglazkov: commit-queue-
Details | Formatted Diff | Diff
second patch with fixed email addr (6.74 KB, patch)
2010-06-17 11:27 PDT, Thomas Van Lenten
no flags Details | Formatted Diff | Diff
Fixing tests part of changelog (6.76 KB, patch)
2010-06-17 11:34 PDT, Thomas Van Lenten
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Van Lenten 2010-06-17 10:59:21 PDT
A bunch of warnings from a -Wextra Chromium Mac build (will become the default).

- checks of unsigned >= 0
- enumeral and non-enumeral type in conditional expression
- copy ctors that don't call the super copy ctor or ctor.
Comment 1 Thomas Van Lenten 2010-06-17 11:11:05 PDT
Created attachment 59018 [details]
proposed patch for the warnings
Comment 2 Dimitri Glazkov (Google) 2010-06-17 11:21:32 PDT
Comment on attachment 59018 [details]
proposed patch for the warnings

ok.

WebCore/platform/chromium/ChromiumDataObject.cpp:70
 +      : RefCounted<ChromiumDataObject>()
Fascinating.
Comment 3 Dimitri Glazkov (Google) 2010-06-17 11:23:25 PDT
Comment on attachment 59018 [details]
proposed patch for the warnings

oops, address is wrong. Can you re-upload with fix?
Comment 4 Thomas Van Lenten 2010-06-17 11:27:14 PDT
Created attachment 59021 [details]
second patch with fixed email addr
Comment 5 Thomas Van Lenten 2010-06-17 11:34:15 PDT
Created attachment 59023 [details]
Fixing tests part of changelog
Comment 6 WebKit Commit Bot 2010-06-19 07:07:11 PDT
Comment on attachment 59023 [details]
Fixing tests part of changelog

Clearing flags on attachment: 59023

Committed r61486: <http://trac.webkit.org/changeset/61486>
Comment 7 WebKit Commit Bot 2010-06-19 07:07:16 PDT
All reviewed patches have been landed.  Closing bug.