Bug 40790 - Fix build break with inspector disabled
Summary: Fix build break with inspector disabled
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ben Murdoch
Depends on:
Reported: 2010-06-17 10:46 PDT by Ben Murdoch
Modified: 2010-06-19 06:55 PDT (History)
3 users (show)

See Also:

Patch. (1.37 KB, patch)
2010-06-17 10:54 PDT, Ben Murdoch
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Murdoch 2010-06-17 10:46:44 PDT
With the inspector not enabled, the build breaks due to the #include of InspectorValues.h in InspectorController.h because the content of InspectorValues is guarded by #if ENABLE(INSPECTOR).

Turns out we don't need the include at all and a forward declaration is enough.

Patch coming.
Comment 1 Ben Murdoch 2010-06-17 10:54:12 PDT
Created attachment 59013 [details]
Comment 2 WebKit Commit Bot 2010-06-19 06:55:01 PDT
Comment on attachment 59013 [details]

Clearing flags on attachment: 59013

Committed r61485: <http://trac.webkit.org/changeset/61485>
Comment 3 WebKit Commit Bot 2010-06-19 06:55:06 PDT
All reviewed patches have been landed.  Closing bug.