Bug 40788 - [GTK] Support for image drags
Summary: [GTK] Support for image drags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 39843 39844
Blocks: 30623
  Show dependency treegraph
 
Reported: 2010-06-17 10:37 PDT by Martin Robinson
Modified: 2010-08-06 09:01 PDT (History)
0 users

See Also:


Attachments
Add image dragging support (14.10 KB, patch)
2010-06-17 10:53 PDT, Martin Robinson
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-06-17 10:37:04 PDT
Dragging images around editable areas or to another application does not work from a GTK+ WebView.
Comment 1 Martin Robinson 2010-06-17 10:53:09 PDT
Created attachment 59012 [details]
Add image dragging support
Comment 2 Gustavo Noronha (kov) 2010-08-06 04:51:35 PDT
Comment on attachment 59012 [details]
Add image dragging support

 314 void ClipboardGtk::declareAndWriteDragImage(Element* element, const KURL& url, const String& label, Frame* frame)
314315 {
315      CachedImage* cachedImage = getCachedImage(element);
316      if (!cachedImage || !cachedImage->isLoaded())
 316     m_dataObject->setURL(url, label);
 317     m_dataObject->setMarkup(createMarkup(element, IncludeNode, 0, AbsoluteURLs));
 318 
 319     CachedImage* image = getCachedImage(element);
 320     if (!image || !image->isLoaded())
317321         return;

So what happens if there is no image? You can then paste the URL or the markup, but not the image, and that's all? Thanks!
Comment 3 Martin Robinson 2010-08-06 09:00:14 PDT
Committed r64852: <http://trac.webkit.org/changeset/64852>
Comment 4 Martin Robinson 2010-08-06 09:01:47 PDT
(In reply to comment #2)
> So what happens if there is no image? You can then paste the URL or the markup, but not the image, and that's all? Thanks!

Thanks for the review!

If, for some reason, the image cannot be placed on the
data object, then there will still be text and markup
available for applications that also support those targets.