Bug 40788 – [GTK] Support for image drags

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

Dragging images around editable areas or to another application does not work from a GTK+ WebView.

[Martin Robinson]

Created attachment 59012 [details]
Add image dragging support

[Gustavo Noronha (kov)]

Comment on attachment 59012 [details]
Add image dragging support

 314 void ClipboardGtk::declareAndWriteDragImage(Element* element, const KURL& url, const String& label, Frame* frame)
314315 {
315      CachedImage* cachedImage = getCachedImage(element);
316      if (!cachedImage || !cachedImage->isLoaded())
 316     m_dataObject->setURL(url, label);
 317     m_dataObject->setMarkup(createMarkup(element, IncludeNode, 0, AbsoluteURLs));
 318 
 319     CachedImage* image = getCachedImage(element);
 320     if (!image || !image->isLoaded())
317321         return;

So what happens if there is no image? You can then paste the URL or the markup, but not the image, and that's all? Thanks!

[Martin Robinson]

Committed r64852: <http://trac.webkit.org/changeset/64852>

[Martin Robinson]

(In reply to comment #2)
> So what happens if there is no image? You can then paste the URL or the markup, but not the image, and that's all? Thanks!

Thanks for the review!

If, for some reason, the image cannot be placed on the
data object, then there will still be text and markup
available for applications that also support those targets.