Bug 40773 - MathML support doesn't build - access to private member in RenderMathMLRoot.cpp
Summary: MathML support doesn't build - access to private member in RenderMathMLRoot.cpp
Status: RESOLVED DUPLICATE of bug 40327
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Nobody
Depends on:
Reported: 2010-06-17 06:06 PDT by red47514f7
Modified: 2010-06-17 08:46 PDT (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description red47514f7 2010-06-17 06:06:59 PDT
[Nightly r61173]

When MathML is enabled, there is a call to RenderStyle's private method color(), which probably should be replaced with visitedDependentColor(CSSPropertyColor).

WebCore/mathml/RenderMathMLRoot.cpp, line 148: 
   info.context->setStrokeColor(style()->color(), sRGBColorSpace);

In WebCore/rendering/style/RenderStyle.h:
line 1109:
const Color visitedDependentColor(int colorProperty) const;
line 1227..1228:
-- cut --
  // Color accessors are all private to make sure callers use visitedDependentColor instead to access them.
-- cut --

in that block (line 1218):    
const Color& color() const { return inherited->color; }
Comment 1 François Sausset 2010-06-17 07:54:41 PDT
You are right.

A patch has just been submitted to solve that problem!

See Bug: https://bugs.webkit.org/show_bug.cgi?id=40327

The status of that bug should be DUPLICATE, but I haven't the rights to do it.
Comment 2 red47514f7 2010-06-17 07:59:11 PDT

*** This bug has been marked as a duplicate of bug 40327 ***
Comment 3 red47514f7 2010-06-17 08:00:38 PDT
Thanks, and sorry for inconvenience. I just thought that was a less widespread leftover problem than it is, and so my search was too narrow.
Comment 4 François Sausset 2010-06-17 08:46:13 PDT
Do not apologize!
Any help, test, etc  about mathml is welcomed as we are only very few ones to work on it.