Bug 40755 – Clean up error conditions for Typed Arrays

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

Based on feedback from Cedric Vivier and others on the public WebGL mailing list, there are several error condition corner cases that need to be clarified or fixed in the Typed Array implementation.

1. For parity with the behavior of "new Array(length)", RangeError should be thrown if the length passed to the ArrayBuffer or ArrayBufferView constructors is negative.
2. INDEX_SIZE_ERR should be thrown when the length passed to the constructor was too large to allocate.
3. INDEX_SIZE_ERR must be thrown when the offset passed to the ArrayBufferView(ArrayBuffer, offset, length) is unaligned, or the offset and length are out of range.
4. Additional null checks are needed in some allocation code paths to prevent crashes.

The unit tests need to be updated to cover more of these cases.

[Kenneth Russell]

Created attachment 58954 [details]
Patch

From the ChangeLog:

Fixed handling of NaN/+inf/-inf lengths. Throw RangeError for too-large or negative lengths. Changed all error code paths to throw exceptions. Clarified exception types. Added necessary null checks during allocation. Added tests for overloaded ArrayBufferView constructors taking null, and improperly aligned offsets. Improved precision of tests causing INDEX_SIZE_ERR to be thrown.

[Eric Seidel (no email)]

Attachment 58954 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/3315260

[Kenneth Russell]

Created attachment 58955 [details]
Revised patch

Fixed build problem on Leopard with last patch.

[Dimitri Glazkov (Google)]

Comment on attachment 58955 [details]
Revised patch

ok.

I am a bit concerned that throwError family is multiplying like rabbits. Should we take away some when add new ones? Like throwError("Foo") already throws a type error by default.

[Kenneth Russell]

Committed r61339: <http://trac.webkit.org/changeset/61339>