Bug 40749 - ResourceLoader::willCacheResponse() needs to null-check m_frame->settings()
Summary: ResourceLoader::willCacheResponse() needs to null-check m_frame->settings()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-06-16 17:14 PDT by Brady Eidson
Modified: 2010-06-16 17:28 PDT (History)
0 users

See Also:


Attachments
Patch v1 (null check and ASSERT) (1.93 KB, patch)
2010-06-16 17:19 PDT, Brady Eidson
eric.carlson: review+
beidson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2010-06-16 17:14:06 PDT
ResourceLoader::willCacheResponse() needs to null-check m_frame->settings()

We've seen crash reports at Apple (<rdar://problem/7249553>) where this method is called on a ResourceLoader, that belongs to a Frame, that no longer has a Page.

Nominally, we think that any Frame without a Page shouldn't have loads occuring, but there is at least one code path where that is not the case, and it's proving elusive to figure out that code path by code inspection.

Plenty of sites in the code null check frame->settings(), and we need to do so here to prevent this crash.
Comment 1 Brady Eidson 2010-06-16 17:19:47 PDT
Created attachment 58947 [details]
Patch v1 (null check and ASSERT)
Comment 2 Brady Eidson 2010-06-16 17:28:17 PDT
http://trac.webkit.org/changeset/61296