WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
40737
SVGRenderSupport doesn't build due to removal of rootFilter from SVGRenderBase::prepareToRenderSVGContent
https://bugs.webkit.org/show_bug.cgi?id=40737
Summary
SVGRenderSupport doesn't build due to removal of rootFilter from SVGRenderBas...
George Wright
Reported
2010-06-16 14:00:23 PDT
SVGRenderBase::prepareToRenderSVGContent used to have an additional parameter rootFilter which was removed in
r60689
, but UNUSED_PARAM() still references it, causing a build failure.
Attachments
Remove UNUSED_PARAM(rootFilter)
(1.57 KB, patch)
2010-06-16 14:12 PDT
,
George Wright
staikos
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
George Wright
Comment 1
2010-06-16 14:12:06 PDT
Created
attachment 58936
[details]
Remove UNUSED_PARAM(rootFilter)
WebKit Commit Bot
Comment 2
2010-06-25 03:32:17 PDT
Comment on
attachment 58936
[details]
Remove UNUSED_PARAM(rootFilter) Rejecting patch 58936 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'George Staikos', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/rendering/SVGRenderSupport.cpp Hunk #1 FAILED at 86. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/rendering/SVGRenderSupport.cpp.rej Full output:
http://webkit-commit-queue.appspot.com/results/3297782
Dirk Schulze
Comment 3
2010-07-01 05:35:56 PDT
All unneeded filter vars were removed. Last commit:
http://trac.webkit.org/changeset/62252
Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug