Add a feature flag ENABLE_BLOB_BUILDER for BlobBuilder (defined in FileWriter).
Currently it's conditionally built with ENABLE_FILE_WRITER flag, but it would make testing or enabling BlobBuilder solely difficult.
Created attachment 58927 [details]
Created attachment 58930 [details]
Comment on attachment 58930 [details]
If BlobBuilder interface works for all platforms, why not making it enabled by default. This way, we do not need to have another feature flag to guard it.
I think the only thing is FileReader does not support reading the binary/hybrid blob created by BlobBuilder but it will get added soon. As long as FileReader throws an exception when encountering a non-file blob, I think it should be fine.
Right, I'll remove the ifdef guard for BlobBuilder (in my next patch) and close this one. Thanks.