Bug 40735 - Add ENABLE_BLOB_BUILDER feature flag for BlobBuilder
Summary: Add ENABLE_BLOB_BUILDER feature flag for BlobBuilder
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 40593
  Show dependency tree / graph
 
Reported: 2010-06-16 13:52 PDT by Kinuko Yasuda
Modified: 2010-06-16 14:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (20.53 KB, patch)
2010-06-16 14:02 PDT, Kinuko Yasuda 		no flags Details | Formatted Diff | Diff
Patch (20.55 KB, patch)
2010-06-16 14:06 PDT, Kinuko Yasuda 		kinuko: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kinuko Yasuda 2010-06-16 13:52:38 PDT 
Add a feature flag ENABLE_BLOB_BUILDER for BlobBuilder (defined in FileWriter).
Currently it's conditionally built with ENABLE_FILE_WRITER flag, but it would make testing or enabling BlobBuilder solely difficult.
Comment 1 Kinuko Yasuda 2010-06-16 14:02:52 PDT 
Created attachment 58927 [details]
Patch
Comment 2 Kinuko Yasuda 2010-06-16 14:06:57 PDT 
Created attachment 58930 [details]
Patch
Comment 3 Jian Li 2010-06-16 14:21:26 PDT 
Comment on attachment 58930 [details]
Patch

If BlobBuilder interface works for all platforms, why not making it enabled by default. This way, we do not need to have another feature flag to guard it.

I think the only thing is FileReader does not support reading the binary/hybrid blob created by BlobBuilder but it will get added soon. As long as FileReader throws an exception when encountering a non-file blob, I think it should be fine.
Comment 4 Kinuko Yasuda 2010-06-16 14:30:59 PDT 
Right, I'll remove the ifdef guard for BlobBuilder (in my next patch) and close this one.   Thanks.