RESOLVED FIXED 40732
WebKit2: Implement didClearWindowForFrame for InjectedBundles 
https://bugs.webkit.org/show_bug.cgi?id=40732
Summary WebKit2: Implement didClearWindowForFrame for InjectedBundles
Sam Weinig
Reported 2010-06-16 13:44:59 PDT
One big obstacle to getting a working DRT is allowing us to inject custom JS objects into pages. We need a form of didClearWindowForFrame for InjectedBundles.
Attachments
patch (30.08 KB, patch)
2010-06-16 13:47 PDT, Sam Weinig 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-06-16 13:47:20 PDT
Created attachment 58925 [details] patch
WebKit Review Bot
Comment 2 2010-06-16 13:49:26 PDT
Attachment 58925 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit2/WebProcess/InjectedBundle/InjectedBundlePageClient.cpp:10: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2010-06-16 17:09:51 PDT
Comment on attachment 58925 [details] patch retvelr+
Anders Carlsson
Comment 4 2010-06-16 17:11:41 PDT
Comment on attachment 58925 [details] patch (Should rename WebBundle in MiniBrowser too)
Sam Weinig
Comment 5 2010-06-16 17:52:14 PDT
Landed in r61297.
Note You need to log in before you can comment on or make changes to this bug.