Bug 40732 - WebKit2: Implement didClearWindowForFrame for InjectedBundles
Summary: WebKit2: Implement didClearWindowForFrame for InjectedBundles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-16 13:44 PDT by Sam Weinig
Modified: 2010-06-16 17:52 PDT (History)
1 user (show)

See Also:


Attachments
patch (30.08 KB, patch)
2010-06-16 13:47 PDT, Sam Weinig
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-06-16 13:44:59 PDT
One big obstacle to getting a working DRT is allowing us to inject custom JS objects into pages.  We need a form of didClearWindowForFrame for InjectedBundles.
Comment 1 Sam Weinig 2010-06-16 13:47:20 PDT
Created attachment 58925 [details]
patch
Comment 2 WebKit Review Bot 2010-06-16 13:49:26 PDT
Attachment 58925 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/InjectedBundlePageClient.cpp:10:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2010-06-16 17:09:51 PDT
Comment on attachment 58925 [details]
patch

retvelr+
Comment 4 Anders Carlsson 2010-06-16 17:11:41 PDT
Comment on attachment 58925 [details]
patch

(Should rename WebBundle in MiniBrowser too)
Comment 5 Sam Weinig 2010-06-16 17:52:14 PDT
Landed in r61297.