Bug 40717 - [Qt] Bridge documentation: some snippets have the wrong indentation
Summary: [Qt] Bridge documentation: some snippets have the wrong indentation
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Keywords: Qt
Depends on:
Reported: 2010-06-16 10:26 PDT by Noam Rosenthal
Modified: 2011-04-19 05:15 PDT (History)
4 users (show)

See Also:

Patch (3.11 KB, patch)
2010-06-16 10:29 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2010-06-16 10:26:30 PDT
Mainly HTML code snippets
Comment 1 Noam Rosenthal 2010-06-16 10:29:49 PDT
Created attachment 58903 [details]
Comment 2 WebKit Review Bot 2010-06-16 10:33:02 PDT
Attachment 58903 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/qt/docs/webkitsnippets/qtwebkit_bridge_snippets.cpp:51:  Should have a space between // and comment  [whitespace/comments] [4]
WebKit/qt/docs/webkitsnippets/qtwebkit_bridge_snippets.cpp:53:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 2 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Noam Rosenthal 2010-06-16 10:35:18 PDT
Posted check-webkit-style false positives, see 40719
Comment 4 WebKit Commit Bot 2010-06-19 04:58:35 PDT
Comment on attachment 58903 [details]

Clearing flags on attachment: 58903

Committed r61480: <http://trac.webkit.org/changeset/61480>
Comment 5 WebKit Commit Bot 2010-06-19 04:58:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Simon Hausmann 2010-06-19 08:47:03 PDT
Revision r61480 cherry-picked into qtwebkit-2.0 with commit 2094af9c87089572f6bc65196dcb40a9719db2cb