Bug 40661 – [Qt] fast/encoding/japanese-encoding-mix.html fails on Qt after enabling HTML5 Lexer

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Eric Seidel (no email)]

fast/encoding/japanese-encoding-mix.html fails on Qt after enabling HTML5 Lexer

I suspect this has to do with Qt's custom encoders.  It looks like the comment isn't properly getting closed, likely because Qt's decoder isn't recognizing the "--" correctly.   Trac also fails to display the "--" before the >, but vi, and other decoders seem to see it fine:
http://trac.webkit.org/browser/trunk/LayoutTests/fast/encoding/japanese-encoding-mix.html

If the decoder isn't passing -- correctly to the HTML5DocumentParser then of course the unclosed comment would eat the rest of the document.  Will need a Qt person to investigate.

--- /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/fast/encoding/japanese-encoding-mix-expected.txt	2010-06-16 01:31:13.436391978 -0700
+++ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/fast/encoding/japanese-encoding-mix-actual.txt	2010-06-16 01:31:13.436391978 -0700
@@ -1,5 +1,12 @@
-Some text here is encoded as EUC-JP, and some (in comment) as Shift_JIS. Since there is an explicit encoding declaration, auto-detection shouldn't change the encoding.
-
-ニッãƒãƒ³ãƒ†ãƒ¬ãƒ“
-
-Should be EUC-JP: EUC-JP
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+    RenderBody {BODY} at (8,8) size 784x576
+      RenderBlock {P} at (0,0) size 784x40
+        RenderText {#text} at (0,0) size 717x40
+          text run at (0,0) width 717: "Some text here is encoded as EUC-JP, and some (in comment) as Shift_JIS. Since there is an explicit"
+          text run at (0,20) width 483: "encoding declaration, auto-detection shouldn't change the encoding."
+      RenderBlock {P} at (0,56) size 784x20
+        RenderText {#text} at (0,0) size 28x20
+          text run at (0,0) width 28: "\x{30CB}\x{30C3}\x{30DD}\x{30F3}\x{30C6}\x{30EC}\x{30D3}"

[Eric Seidel (no email)]

Created attachment 58863 [details]
Skipping for now

[Eric Seidel (no email)]

Committed r61246: <http://trac.webkit.org/changeset/61246>

[Eric Seidel (no email)]

Bug 40725 is the same failure except for Tiger (which also has different decoders).

[Zoltan Arvai]

This test is no longer on skipped list.
It passes:
http://build.webkit.org/builders/Qt%20Linux%20Release/builds/38749/steps/layout-test/logs/stdio