Full screen video in Safari exits full-screen if you switch to another app

[Jer Noble]

Full screen video in Safari exits full-screen if you switch to another app

[Jer Noble]

If on a dual screen setup you full screen an embedded HTML5 video, and then go to the other screen and try to bring up another window, the full screen video un-full screens.

[Jer Noble]

<rdar://problem/7885101>

[Jer Noble]

Created attachment 58816 [details]
Patch

[Mark Rowe (bdash)]

You’ll want to make sure that you remove the observer at some point too.

[Jer Noble]

(In reply to comment #4)
> You’ll want to make sure that you remove the observer at some point too.

The observer is removed in -(void)dealloc, when [[NSNotificationCenter defaultCenter] removeObserver:self] is called.  This removes all observers, regardless of key and object.

[Eric Seidel (no email)]

Attachment 58816 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/3304529

[Jer Noble]

Created attachment 59289 [details]
Patch

[Eric Carlson]

Comment on attachment 59289 [details]
Patch


WebKit/mac/WebView/WebVideoFullscreenController.mm:196
 +  - (void)applicationDidResignActive:(NSNotification*)notification
Should have a space between type and *

WebKit/mac/WebView/WebVideoFullscreenController.mm:200
 +      NSWindow* fullscreenWindow = [self fullscreenWindow];
Same here

[Jer Noble]

Committed r61796: <http://trac.webkit.org/changeset/61796>

Committed r61786: <http://trac.webkit.org/changeset/61786>

[Jer Noble]

Disregard above comment.

Committed r61796: <http://trac.webkit.org/changeset/61796>