Bug 40628 - Update CMake build system to use new gperf code generation
Summary: Update CMake build system to use new gperf code generation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P1 Blocker
Assignee: Lucas De Marchi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-15 09:53 PDT by Lucas De Marchi
Modified: 2010-06-17 07:50 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.97 KB, patch)
2010-06-15 09:54 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas De Marchi 2010-06-15 09:53:08 PDT
Update CMake build system to use new gperf code generation
Comment 1 Lucas De Marchi 2010-06-15 09:54:07 PDT
Created attachment 58790 [details]
Patch
Comment 2 Andras Becsi 2010-06-16 00:46:30 PDT
Seems ok to me. Thanks for doing that.

(In reply to comment #1)
> Created an attachment (id=58790) [details]
> Patch
Comment 3 Lucas De Marchi 2010-06-17 04:40:55 PDT
This is a build fix that is blocking our development so I'm raising the priority.
Comment 4 Gustavo Noronha (kov) 2010-06-17 06:14:42 PDT
Comment on attachment 58790 [details]
Patch

I thought you had a commiter by now? =) You should really consider setting up a build bot, asap too.
Comment 5 Andras Becsi 2010-06-17 07:34:17 PDT
Comment on attachment 58790 [details]
Patch

Removing cq+ to land the patch manually.
Comment 6 Andras Becsi 2010-06-17 07:49:32 PDT
Comment on attachment 58790 [details]
Patch

Sending        ChangeLog
Sending        WebCore/CMakeLists.txt
Sending        WebCore/ChangeLog
Sending        cmake/WebKitGenerators.cmake
Transmitting file data ....
Committed revision 61323.

Removing flags.
Comment 7 Andras Becsi 2010-06-17 07:50:12 PDT
All reviewed patches landed. Closing bug.