Bug 40624 - [Qt] Build fix for Qt minimal after r61121
Summary: [Qt] Build fix for Qt minimal after r61121
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-06-15 08:28 PDT by Yael
Modified: 2010-06-15 09:10 PDT (History)
2 users (show)

See Also:

Attachments
Patch build fix (4.18 KB, patch)
2010-06-15 08:32 PDT, Yael 		ossy: review-
Details | Formatted Diff | Diff
Patch, V2 (4.57 KB, patch)
2010-06-15 08:54 PDT, Yael 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2010-06-15 08:28:05 PDT 
[Qt] Build fix for Qt minimal after r61121
Comment 1 Yael 2010-06-15 08:32:25 PDT 
Created attachment 58782 [details]
Patch build fix

I am in the process of compiling this patch, so I don't know yet if it will compile. 
Since my machine is slow and this is blocking the commit queue, I want to take advantage of the faster build bots.
Comment 2 Early Warning System Bot 2010-06-15 08:42:10 PDT 
Attachment 58782 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/3283174
Comment 3 Csaba Osztrogonác 2010-06-15 08:47:26 PDT 
1.(
please remove unnecessary #endif from WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:356

2.)
namespace WebCore is inside #if ENABLE(NOTIFICATIONS) -> it is incorrect

3.)
After 1.) and 2.) fixed: 
implementation of NotificationPresenterClientQt::NotificationPresenterClientQt() cause build error, because 'NotificationPresenterClientQt' has not been declared
Comment 4 Csaba Osztrogonác 2010-06-15 08:48:51 PDT 
Comment on attachment 58782 [details]
Patch build fix

r- -ed now, because it is incomplete now
Comment 5 Yael 2010-06-15 08:54:09 PDT 
Created attachment 58783 [details]
Patch, V2
Comment 6 Csaba Osztrogonác 2010-06-15 09:02:17 PDT 
(In reply to comment #5)
> Created an attachment (id=58783) [details]
> Patch, V2

Now LGTM. I can't give you an r+, because I'm not a reviewer,
but it is a buildfix, so it doesn't need a review, just commit
it as an unreviewed buildfix. Or you can ask a rubber stamp 
on #qtwebkit.
Comment 7 Yael 2010-06-15 09:10:54 PDT 
Committed r61187: <http://trac.webkit.org/changeset/61187>