RESOLVED FIXED Bug 40624
[Qt] Build fix for Qt minimal after r61121 
https://bugs.webkit.org/show_bug.cgi?id=40624
Summary [Qt] Build fix for Qt minimal after r61121
Yael
Reported 2010-06-15 08:28:05 PDT
[Qt] Build fix for Qt minimal after r61121
Attachments
Patch build fix (4.18 KB, patch)
2010-06-15 08:32 PDT, Yael 		ossy: review-
DetailsFormatted DiffDiff
Patch, V2 (4.57 KB, patch)
2010-06-15 08:54 PDT, Yael 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2010-06-15 08:32:25 PDT
Created attachment 58782 [details] Patch build fix I am in the process of compiling this patch, so I don't know yet if it will compile. Since my machine is slow and this is blocking the commit queue, I want to take advantage of the faster build bots.
Early Warning System Bot
Comment 2 2010-06-15 08:42:10 PDT
Attachment 58782 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/3283174
Csaba Osztrogonác
Comment 3 2010-06-15 08:47:26 PDT
1.( please remove unnecessary #endif from WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:356 2.) namespace WebCore is inside #if ENABLE(NOTIFICATIONS) -> it is incorrect 3.) After 1.) and 2.) fixed: implementation of NotificationPresenterClientQt::NotificationPresenterClientQt() cause build error, because 'NotificationPresenterClientQt' has not been declared
Csaba Osztrogonác
Comment 4 2010-06-15 08:48:51 PDT
Comment on attachment 58782 [details] Patch build fix r- -ed now, because it is incomplete now
Yael
Comment 5 2010-06-15 08:54:09 PDT
Created attachment 58783 [details] Patch, V2
Csaba Osztrogonác
Comment 6 2010-06-15 09:02:17 PDT
(In reply to comment #5) > Created an attachment (id=58783) [details] > Patch, V2 Now LGTM. I can't give you an r+, because I'm not a reviewer, but it is a buildfix, so it doesn't need a review, just commit it as an unreviewed buildfix. Or you can ask a rubber stamp on #qtwebkit.
Yael
Comment 7 2010-06-15 09:10:54 PDT
Committed r61187: <http://trac.webkit.org/changeset/61187>
Note You need to log in before you can comment on or make changes to this bug.