Bug 40603 - Remove input parameter validation for "level" upper limit in *tex* functions
Summary: Remove input parameter validation for "level" upper limit in *tex* functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on: 38145
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-14 18:14 PDT by Zhenyao Mo
Modified: 2010-06-17 09:39 PDT (History)
7 users (show)

See Also:


Attachments
patch (2.04 KB, patch)
2010-06-14 18:24 PDT, Zhenyao Mo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2010-06-14 18:14:44 PDT
According to GLES 2.0.24 Spec, there is no hard limit as level < log2(MAX_TEXTURE_SIZE).  It only says the maximum allowable width/height may be zero for image arrays of any level-of-detail greater than log2(MAX_TEXTURE_SIZE).

In this case, we should remove the code that checks the level upper limit.
Comment 1 Zhenyao Mo 2010-06-14 18:24:56 PDT
Created attachment 58738 [details]
patch
Comment 2 David Levin 2010-06-15 00:00:10 PDT
(In reply to comment #0)
> According to GLES 2.0.24 Spec, there is no hard limit as level < log2(MAX_TEXTURE_SIZE).  It only says the maximum allowable width/height may be zero for image arrays of any level-of-detail greater than log2(MAX_TEXTURE_SIZE).
> 
> In this case, we should remove the code that checks the level upper limit.

Would have been nice to say some version of this in the ChangeLog (imo) as it would help anyone trying to understand why the change was done.

Regardless, at least it is in the bug so they can't find it if needed.
Comment 3 WebKit Commit Bot 2010-06-17 09:39:48 PDT
Comment on attachment 58738 [details]
patch

Clearing flags on attachment: 58738

Committed r61332: <http://trac.webkit.org/changeset/61332>
Comment 4 WebKit Commit Bot 2010-06-17 09:39:52 PDT
All reviewed patches have been landed.  Closing bug.