Bug 40600 - [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
Summary: [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 39844
  Show dependency treegraph
 
Reported: 2010-06-14 17:09 PDT by Martin Robinson
Modified: 2010-06-16 15:27 PDT (History)
0 users

See Also:


Attachments
Patch for this issue (10.61 KB, patch)
2010-06-14 17:31 PDT, Martin Robinson
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-06-14 17:09:30 PDT
In a previous patch, I abused GDK_CURRENT_TIME by adding the current offset to it (from leapForward). GTK+ drag-and-drop internals respond poorly to this, so I need to remove it before adding dropping support the GTK+ DRT.
Comment 1 Martin Robinson 2010-06-14 17:31:27 PDT
Created attachment 58733 [details]
Patch for this issue
Comment 2 Martin Robinson 2010-06-14 17:33:55 PDT
I've uploaded a patch for this issue. Unfortunately, the fix has uncovered failures in four tests that were passing incorrectly. I've opened bug #40601 for this issue.
Comment 3 Gustavo Noronha (kov) 2010-06-16 13:59:00 PDT
Comment on attachment 58733 [details]
Patch for this issue

Finding false positives is also a good thing, I guess =)
Comment 4 Martin Robinson 2010-06-16 15:27:01 PDT
Committed r61288: <http://trac.webkit.org/changeset/61288>