WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 40600
[GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
https://bugs.webkit.org/show_bug.cgi?id=40600
Summary
[GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
Martin Robinson
Reported
2010-06-14 17:09:30 PDT
In a previous patch, I abused GDK_CURRENT_TIME by adding the current offset to it (from leapForward). GTK+ drag-and-drop internals respond poorly to this, so I need to remove it before adding dropping support the GTK+ DRT.
Attachments
Patch for this issue
(10.61 KB, patch)
2010-06-14 17:31 PDT
,
Martin Robinson
gustavo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Martin Robinson
Comment 1
2010-06-14 17:31:27 PDT
Created
attachment 58733
[details]
Patch for this issue
Martin Robinson
Comment 2
2010-06-14 17:33:55 PDT
I've uploaded a patch for this issue. Unfortunately, the fix has uncovered failures in four tests that were passing incorrectly. I've opened
bug #40601
for this issue.
Gustavo Noronha (kov)
Comment 3
2010-06-16 13:59:00 PDT
Comment on
attachment 58733
[details]
Patch for this issue Finding false positives is also a good thing, I guess =)
Martin Robinson
Comment 4
2010-06-16 15:27:01 PDT
Committed
r61288
: <
http://trac.webkit.org/changeset/61288
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug