Bug 40581 - Autogenerate most of the JS constructors
Summary: Autogenerate most of the JS constructors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-14 11:57 PDT by Sam Weinig
Modified: 2010-06-15 04:38 PDT (History)
7 users (show)

See Also:


Attachments
patch (262.45 KB, patch)
2010-06-14 12:28 PDT, Sam Weinig
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-06-14 11:57:11 PDT
Autogenerate most of the JS constructors now that we can do a custom construct function.
Comment 1 Sam Weinig 2010-06-14 12:28:44 PDT
Created attachment 58686 [details]
patch
Comment 2 Adam Barth 2010-06-14 12:33:25 PDT
Comment on attachment 58686 [details]
patch

Sam, you are my WebKit Hacker of the Week.
Comment 3 Alexey Proskuryakov 2010-06-14 12:35:42 PDT
Comment on attachment 58686 [details]
patch

You fixed bug 35140!

> Fixes a bug where the new XSLTConstructor().toString() had a

And EventSource!

r=me
Comment 4 Sam Weinig 2010-06-14 12:46:34 PDT
Landed in r61136.
Comment 5 WebKit Review Bot 2010-06-14 12:53:20 PDT
http://trac.webkit.org/changeset/61136 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Linux ARMv7 Release, and Chromium Linux Release
Comment 6 Csaba Osztrogonác 2010-06-14 13:46:26 PDT
(In reply to comment #5)
> http://trac.webkit.org/changeset/61136 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Linux ARMv7 Release, and Chromium Linux Release

Rebaseline for Qt port landed in http://trac.webkit.org/changeset/61142.
Comment 7 Eric Seidel (no email) 2010-06-14 19:46:59 PDT
I think this caused global-constructors.html to fail for Gtk:
--- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/fast/js/global-constructors-expected.txt	2010-06-14 18:55:20.000000000 -0700
+++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/fast/js/global-constructors-actual.txt	2010-06-14 18:55:20.000000000 -0700
@@ -44,6 +44,7 @@
 PASS EntityReference.toString() is '[object EntityReferenceConstructor]'
 PASS Event.toString() is '[object EventConstructor]'
 PASS EventException.toString() is '[object EventExceptionConstructor]'
+PASS EventSource.toString() is '[object EventSourceConstructor]'
 PASS File.toString() is '[object FileConstructor]'
 PASS FileList.toString() is '[object FileListConstructor]'
 PASS FormData.toString() is '[object FormDataConstructor]'
@@ -298,6 +299,7 @@
 PASS XPathEvaluator.toString() is '[object XPathEvaluatorConstructor]'
 PASS XPathException.toString() is '[object XPathExceptionConstructor]'
 PASS XPathResult.toString() is '[object XPathResultConstructor]'
+PASS XSLTProcessor.toString() is '[object XSLTProcessorConstructor]'
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 8 Alejandro G. Castro 2010-06-15 04:38:47 PDT
(In reply to comment #7)
> I think this caused global-constructors.html to fail for Gtk:
> --- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/fast/js/global-constructors-expected.txt    2010-06-14 18:55:20.000000000 -0700
> +++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/fast/js/global-constructors-actual.txt    2010-06-14 18:55:20.000000000 -0700
> @@ -44,6 +44,7 @@
>  PASS EntityReference.toString() is '[object EntityReferenceConstructor]'
>  PASS Event.toString() is '[object EventConstructor]'
>  PASS EventException.toString() is '[object EventExceptionConstructor]'
> +PASS EventSource.toString() is '[object EventSourceConstructor]'
>  PASS File.toString() is '[object FileConstructor]'
>  PASS FileList.toString() is '[object FileListConstructor]'
>  PASS FormData.toString() is '[object FormDataConstructor]'
> @@ -298,6 +299,7 @@
>  PASS XPathEvaluator.toString() is '[object XPathEvaluatorConstructor]'
>  PASS XPathException.toString() is '[object XPathExceptionConstructor]'
>  PASS XPathResult.toString() is '[object XPathResultConstructor]'
> +PASS XSLTProcessor.toString() is '[object XSLTProcessorConstructor]'
>  PASS successfullyParsed is true
> 
>  TEST COMPLETE

It seems we have a different expected for that test in gtk (not sure why) and it needs that modification. I'm going to upload a patch.