Bug 40580 - [Qt] Don't connect to microFocusChanged() if _q_updateMicroFocus is a noop.
Summary: [Qt] Don't connect to microFocusChanged() if _q_updateMicroFocus is a noop.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-06-14 11:54 PDT by Anders Bakken
Modified: 2010-08-10 22:40 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.87 KB, patch)
2010-06-14 11:56 PDT, Anders Bakken
no flags Details | Formatted Diff | Diff
Patch (3.56 KB, patch)
2010-06-14 12:04 PDT, Anders Bakken
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Bakken 2010-06-14 11:54:03 PDT
[Qt] Don't connect to microFocusChanged() if _q_updateMicroFocus is a noop.
Comment 1 Anders Bakken 2010-06-14 11:56:52 PDT
Created attachment 58679 [details]
Patch
Comment 2 Anders Bakken 2010-06-14 12:04:30 PDT
Created attachment 58680 [details]
Patch
Comment 3 Jędrzej Nowacki 2010-06-15 05:59:57 PDT
Are you sure that we need to keep this function for different define values? Maybe we can remove it completely. According to an information in comment it should be safely to remove the function, because the bug (http://bugreports.qt.nokia.com/browse/QTBUG-7578) is closed.

Simon what do you think?
Comment 4 Adam Barth 2010-08-10 22:10:26 PDT
Comment on attachment 58680 [details]
Patch

This patch looks ready to land.
Comment 5 WebKit Commit Bot 2010-08-10 22:40:22 PDT
Comment on attachment 58680 [details]
Patch

Clearing flags on attachment: 58680

Committed r65124: <http://trac.webkit.org/changeset/65124>
Comment 6 WebKit Commit Bot 2010-08-10 22:40:26 PDT
All reviewed patches have been landed.  Closing bug.