Bug 40575 - Clean EFL includes from headers
Summary: Clean EFL includes from headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Lucas De Marchi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-14 09:42 PDT by Lucas De Marchi
Modified: 2010-06-17 09:26 PDT (History)
4 users (show)

See Also:


Attachments
Patch (15.88 KB, patch)
2010-06-14 09:44 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff
Patch (16.61 KB, patch)
2010-06-14 16:00 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas De Marchi 2010-06-14 09:42:09 PDT
Clean EFL includes from headers
Comment 1 Lucas De Marchi 2010-06-14 09:44:47 PDT
Created attachment 58665 [details]
Patch
Comment 2 WebKit Review Bot 2010-06-14 09:48:34 PDT
Attachment 58665 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/PlatformKeyboardEvent.h:66:  Evas_Event_Key_Down is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/PlatformKeyboardEvent.h:67:  Evas_Event_Key_Up is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/efl/WebCoreSupport/EditorClientEfl.h:40:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:53:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/graphics/Icon.h:43:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/PlatformMouseEvent.h:37:  Evas_Event_Mouse_Down is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/PlatformMouseEvent.h:38:  Evas_Event_Mouse_Up is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/PlatformMouseEvent.h:39:  Evas_Event_Mouse_Move is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/efl/RenderThemeEfl.h:37:  Ecore_Evas is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/efl/RenderThemeEfl.h:38:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/PlatformWheelEvent.h:36:  Evas_Event_Mouse_Wheel is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/Widget.h:76:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/Widget.h:78:  Ecore_Evas is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/efl/RenderThemeEfl.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/efl/WebCoreSupport/ChromeClientEfl.h:30:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 15 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Lucas De Marchi 2010-06-14 09:59:29 PDT
(In reply to comment #2)
> Attachment 58665 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" 

These style issues are either needed, because they name a type of EFL library or were not introduced by this patch (alphabetical sorting of headers).
Comment 4 Lucas De Marchi 2010-06-14 10:33:55 PDT
I've put Eric as CC since he is involved in cleaning header files in order to speed up compilation.
Comment 5 Eric Seidel (no email) 2010-06-14 11:59:59 PDT
Comment on attachment 58665 [details]
Patch

Sad to lose the type specificity of Evas_Button_Flags, but this looks fine.
Comment 6 Lucas De Marchi 2010-06-14 14:18:23 PDT
Comment on attachment 58665 [details]
Patch

Forgot to remove the files from CMake. New patch is coming...
Comment 7 Lucas De Marchi 2010-06-14 16:00:11 PDT
Created attachment 58722 [details]
Patch
Comment 8 WebKit Review Bot 2010-06-14 16:02:12 PDT
Attachment 58722 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/PlatformKeyboardEvent.h:66:  Evas_Event_Key_Down is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/PlatformKeyboardEvent.h:67:  Evas_Event_Key_Up is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/efl/WebCoreSupport/EditorClientEfl.h:40:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:53:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/graphics/Icon.h:43:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/PlatformMouseEvent.h:37:  Evas_Event_Mouse_Down is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/PlatformMouseEvent.h:38:  Evas_Event_Mouse_Up is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/PlatformMouseEvent.h:39:  Evas_Event_Mouse_Move is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/efl/RenderThemeEfl.h:37:  Ecore_Evas is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/efl/RenderThemeEfl.h:38:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/PlatformWheelEvent.h:36:  Evas_Event_Mouse_Wheel is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/Widget.h:76:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/Widget.h:78:  Ecore_Evas is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/efl/RenderThemeEfl.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/efl/WebCoreSupport/ChromeClientEfl.h:30:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 15 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Eric Seidel (no email) 2010-06-14 16:17:28 PDT
Comment on attachment 58722 [details]
Patch

OK.
Comment 10 WebKit Commit Bot 2010-06-17 09:26:26 PDT
Comment on attachment 58722 [details]
Patch

Clearing flags on attachment: 58722

Committed r61331: <http://trac.webkit.org/changeset/61331>
Comment 11 WebKit Commit Bot 2010-06-17 09:26:32 PDT
All reviewed patches have been landed.  Closing bug.