Bug 40572 - [Qt] Stack overflow when converting navigator object to QVariant
Summary: [Qt] Stack overflow when converting navigator object to QVariant
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Qt, QtTriaged
: 41750 (view as bug list)
Depends on:
Blocks: 35784
  Show dependency tree / graph
 
Reported: 2010-06-14 08:01 PDT by Andreas Kling
Modified: 2010-08-03 05:10 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (9.24 KB, patch)
2010-06-14 08:02 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Proposed patch v2 (9.17 KB, patch)
2010-06-14 08:14 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-06-14 08:01:01 PDT 
The navigator object is infinitely recursive thanks to MimeType and Plugin.
When converting it from a JSValue to a QVariant, we crash due to stack overflow.
Comment 1 Andreas Kling 2010-06-14 08:02:16 PDT 
Created attachment 58649 [details]
Proposed patch
Comment 2 Andreas Kling 2010-06-14 08:14:42 PDT 
Created attachment 58653 [details]
Proposed patch v2

Lowered recursion limit to 200 (40000 was too big for default ulimit -s value on Linux.)
Comment 3 WebKit Commit Bot 2010-06-14 09:38:29 PDT 
Comment on attachment 58653 [details]
Proposed patch v2

Clearing flags on attachment: 58653

Committed r61127: <http://trac.webkit.org/changeset/61127>
Comment 4 WebKit Commit Bot 2010-06-14 09:38:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Andreas Kling 2010-07-08 12:15:09 PDT 
*** Bug 41750 has been marked as a duplicate of this bug. ***
Comment 6 Simon Hausmann 2010-08-03 05:10:02 PDT 
Revision r61127 cherry-picked into qtwebkit-2.0 with commit d6aa024c84f61d0602bef4eef84efaed7cfeefcc