Address review comments (https://bugs.webkit.org/show_bug.cgi?id=39950#c7) and improve assertion macro documentation.
Created attachment 58637 [details] Improve assertion documentation
Comment on attachment 58637 [details] Improve assertion documentation These changes look good. I think that it’s overstating the case to say that out of memory errors are not recoverable. Maybe there’s a more nuanced way to talk about this. Because of virtual memory systems we program assuming we will not run out of memory for small allocation, and we don't wish to rewrite all the code to handle out-of-memory errors. In those cases we want to terminate the program if we can’t get the memory. But we do have functions that return 0 if there is not sufficient memory. We tend to use those for larger allocations that might fail in practice even if the program has ample space to continue. The topic is generally subtle and just stating that memory errors are unrecoverable is imprecise.
Comment on attachment 58637 [details] Improve assertion documentation Clearing flags on attachment: 58637 Committed r61305: <http://trac.webkit.org/changeset/61305>
All reviewed patches have been landed. Closing bug.