Add stubs for OOP font loading to Chromium WebKit API on OSX
Created attachment 58590 [details] patch 1 With this patch, there will be versions of WebSandboxSupport for Mac/Windows & Linux.
Comment on attachment 58590 [details] patch 1 WebCore/platform/chromium/ChromiumBridge.h:143 + #endif nit: please add a new line after the #endif WebKit/chromium/src/ChromiumBridge.cpp:410 + return ss ? ss->loadFont(srcFont, out) : true; why return true when there is no sandbox support? shouldn't you also do |*out = 0;| before returning? WebCore/platform/chromium/ChromiumBridge.h:50 + nit: no need for this new line here. it is nice to keep the OS(DARWIN) block as one contiguous block since it is fairly small.
Created attachment 58755 [details] patch 2 As noted in the comment, loadFont() should only be called when font loading is blocked by the Sandbox. This is a distinct error from any other font loading error and thus if the function is called with the Sandbox not present, that would indicate a programming error.
Comment on attachment 58755 [details] patch 2 Clearing flags on attachment: 58755 Committed r61361: <http://trac.webkit.org/changeset/61361>
All reviewed patches have been landed. Closing bug.