Bug 40544 - [Chromium] Add stubs for OOP font loading to Chromium WebKit API on OSX.
Summary: [Chromium] Add stubs for OOP font loading to Chromium WebKit API on OSX.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-13 04:32 PDT by Jeremy Moskovich
Modified: 2010-06-17 17:24 PDT (History)
3 users (show)

See Also:


Attachments
patch 1 (6.97 KB, patch)
2010-06-13 04:39 PDT, Jeremy Moskovich
fishd: review-
Details | Formatted Diff | Diff
patch 2 (7.24 KB, patch)
2010-06-14 23:14 PDT, Jeremy Moskovich
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Moskovich 2010-06-13 04:32:20 PDT
Add stubs for OOP font loading to Chromium WebKit API on OSX
Comment 1 Jeremy Moskovich 2010-06-13 04:39:49 PDT
Created attachment 58590 [details]
patch 1

With this patch, there will be versions of WebSandboxSupport for Mac/Windows & Linux.
Comment 2 Darin Fisher (:fishd, Google) 2010-06-14 11:46:34 PDT
Comment on attachment 58590 [details]
patch 1

WebCore/platform/chromium/ChromiumBridge.h:143
 +  #endif
nit: please add a new line after the #endif

WebKit/chromium/src/ChromiumBridge.cpp:410
 +      return ss ? ss->loadFont(srcFont, out) : true;
why return true when there is no sandbox support?  shouldn't you also do |*out = 0;| before returning?

WebCore/platform/chromium/ChromiumBridge.h:50
 +  
nit: no need for this new line here.  it is nice to keep the OS(DARWIN)
block as one contiguous block since it is fairly small.
Comment 3 Jeremy Moskovich 2010-06-14 23:14:56 PDT
Created attachment 58755 [details]
patch 2

As noted in the comment, loadFont() should only be called when font loading is blocked by the Sandbox.  This is a distinct error from any other font loading error and thus if the function is called with the Sandbox not present, that would indicate a programming error.
Comment 4 WebKit Commit Bot 2010-06-17 17:24:16 PDT
Comment on attachment 58755 [details]
patch 2

Clearing flags on attachment: 58755

Committed r61361: <http://trac.webkit.org/changeset/61361>
Comment 5 WebKit Commit Bot 2010-06-17 17:24:21 PDT
All reviewed patches have been landed.  Closing bug.