RESOLVED FIXED 40538
Build error: WebCore.lib : fatal error LNK1106: invalid file or disk full. 
https://bugs.webkit.org/show_bug.cgi?id=40538
Summary Build error: WebCore.lib : fatal error LNK1106: invalid file or disk full.
Ada Chan
Reported 2010-06-12 22:00:16 PDT
Some machines have started to see the return of the dreaded: WebCore.lib : fatal error LNK1106: invalid file or disk full. Since we don't have the hotfix for VS2005, work around this in the meantime by creating an EditingAllInOne file, that includes all of the cpp files in the editing subdirectory.
Attachments
Patch, sending this on behalf of Brian Weinstein (72.75 KB, patch)
2010-06-12 22:14 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
Patch - fixing a few alphabetical sorting errors from last version (72.75 KB, patch)
2010-06-12 22:32 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
Patch - take 3 (72.75 KB, patch)
2010-06-12 22:39 PDT, Ada Chan 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2010-06-12 22:14:20 PDT
Created attachment 58580 [details] Patch, sending this on behalf of Brian Weinstein
WebKit Review Bot
Comment 2 2010-06-12 22:15:19 PDT
Attachment 58580 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/editing/EditingAllInOne.cpp:28: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/editing/EditingAllInOne.cpp:42: Alphabetical sorting problem. [build/include_order] [4] WebCore/editing/EditingAllInOne.cpp:52: Alphabetical sorting problem. [build/include_order] [4] WebCore/editing/EditingAllInOne.cpp:72: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ada Chan
Comment 3 2010-06-12 22:32:04 PDT
Created attachment 58582 [details] Patch - fixing a few alphabetical sorting errors from last version
WebKit Review Bot
Comment 4 2010-06-12 22:34:35 PDT
Attachment 58582 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/editing/EditingAllInOne.cpp:28: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/editing/EditingAllInOne.cpp:43: Alphabetical sorting problem. [build/include_order] [4] WebCore/editing/EditingAllInOne.cpp:55: Alphabetical sorting problem. [build/include_order] [4] WebCore/editing/EditingAllInOne.cpp:74: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 5 2010-06-12 22:38:14 PDT
Comment on attachment 58582 [details] Patch - fixing a few alphabetical sorting errors from last version rs=me Even though the style error message says “alphabetical sorting”, the #includes should be in ASCII order.
Ada Chan
Comment 6 2010-06-12 22:39:46 PDT
Created attachment 58583 [details] Patch - take 3
WebKit Review Bot
Comment 7 2010-06-12 22:41:39 PDT
Attachment 58583 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/editing/EditingAllInOne.cpp:28: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 8 2010-06-12 22:43:35 PDT
Comment on attachment 58583 [details] Patch - take 3 rs=me again
Eric Seidel (no email)
Comment 9 2010-06-16 03:15:44 PDT
Comment on attachment 58582 [details] Patch - fixing a few alphabetical sorting errors from last version Cleared Dan Bernstein's review+ from obsolete attachment 58582 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Adam Barth
Comment 10 2010-08-11 10:17:10 PDT
This patch appears to have been landed.
Note You need to log in before you can comment on or make changes to this bug.