RESOLVED FIXED 40514
Rename m_parser, htmlParser() to m_treeBuilder, htmlTreeBuilder() in preparation for renaming HTMLParser 
https://bugs.webkit.org/show_bug.cgi?id=40514
Summary Rename m_parser, htmlParser() to m_treeBuilder, htmlTreeBuilder() in preparat...
Eric Seidel (no email)
Reported 2010-06-11 19:06:51 PDT
Rename m_parser, htmlParser() to m_treeBuilder, htmlTreeBuilder() in preparation for renaming HTMLParser
Attachments
Patch (14.46 KB, patch)
2010-06-11 19:11 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.17 KB, patch)
2010-06-13 18:13 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.01 KB, patch)
2010-06-13 21:01 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-06-11 19:11:45 PDT
Created attachment 58539 [details] Patch
Darin Adler
Comment 2 2010-06-12 09:57:25 PDT
Comment on attachment 58539 [details] Patch > - , m_parser(0) > + , m_treeBuilder(0) This line of code could just be deleted instead.
WebKit Commit Bot
Comment 3 2010-06-12 10:52:39 PDT
Comment on attachment 58539 [details] Patch Rejecting patch 58539 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Last 500 characters of output: ------------------------- |Index: WebCore/html/HTMLDocumentParser.h |index 0951c2a358d0d81416792931e1601a2941b2af1c..1d9ebf7117e50b96fba8d8b3f6d00b22073b0568 100644 |--- WebCore/html/HTMLDocumentParser.h |+++ WebCore/html/HTMLDocumentParser.h -------------------------- No file to patch. Skipping patch. 2 out of 2 hunks ignored patching file WebCore/html/HTMLFormControlElement.cpp Hunk #1 FAILED at 178. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLFormControlElement.cpp.rej Full output: http://webkit-commit-queue.appspot.com/results/3216363
WebKit Commit Bot
Comment 4 2010-06-13 00:42:15 PDT
Comment on attachment 58539 [details] Patch Rejecting patch 58539 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Last 500 characters of output: html/HTML5DocumentParser.h patching file WebCore/html/HTML5TreeBuilder.cpp patching file WebCore/html/HTML5TreeBuilder.h patching file WebCore/html/HTMLDocumentParser.cpp patching file WebCore/html/HTMLDocumentParser.h Hunk #1 FAILED at 163. 1 out of 2 hunks FAILED -- saving rejects to file WebCore/html/HTMLDocumentParser.h.rej patching file WebCore/html/HTMLFormControlElement.cpp Hunk #1 FAILED at 178. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLFormControlElement.cpp.rej Full output: http://webkit-commit-queue.appspot.com/results/3272030
Eric Seidel (no email)
Comment 5 2010-06-13 18:13:28 PDT
Created attachment 58610 [details] Patch for landing
Eric Seidel (no email)
Comment 6 2010-06-13 21:01:19 PDT
Created attachment 58618 [details] Patch for landing
Adam Barth
Comment 7 2010-06-13 21:48:51 PDT
Comment on attachment 58618 [details] Patch for landing Clearing flags on attachment: 58618 Committed r61106: <http://trac.webkit.org/changeset/61106>
Adam Barth
Comment 8 2010-06-13 21:48:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.