Bug 40514 - Rename m_parser, htmlParser() to m_treeBuilder, htmlTreeBuilder() in preparation for renaming HTMLParser
Summary: Rename m_parser, htmlParser() to m_treeBuilder, htmlTreeBuilder() in preparat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-11 19:06 PDT by Eric Seidel (no email)
Modified: 2010-06-13 21:48 PDT (History)
2 users (show)

See Also:

Attachments
Patch (14.46 KB, patch)
2010-06-11 19:11 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch for landing (14.17 KB, patch)
2010-06-13 18:13 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch for landing (20.01 KB, patch)
2010-06-13 21:01 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-06-11 19:06:51 PDT 
Rename m_parser, htmlParser() to m_treeBuilder, htmlTreeBuilder() in preparation for renaming HTMLParser
Comment 1 Eric Seidel (no email) 2010-06-11 19:11:45 PDT 
Created attachment 58539 [details]
Patch
Comment 2 Darin Adler 2010-06-12 09:57:25 PDT 
Comment on attachment 58539 [details]
Patch

> -    , m_parser(0)
> +    , m_treeBuilder(0)

This line of code could just be deleted instead.
Comment 3 WebKit Commit Bot 2010-06-12 10:52:39 PDT 
Comment on attachment 58539 [details]
Patch

Rejecting patch 58539 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1
Last 500 characters of output:
-------------------------
|Index: WebCore/html/HTMLDocumentParser.h
|index 0951c2a358d0d81416792931e1601a2941b2af1c..1d9ebf7117e50b96fba8d8b3f6d00b22073b0568 100644
|--- WebCore/html/HTMLDocumentParser.h
|+++ WebCore/html/HTMLDocumentParser.h
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
patching file WebCore/html/HTMLFormControlElement.cpp
Hunk #1 FAILED at 178.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLFormControlElement.cpp.rej

Full output: http://webkit-commit-queue.appspot.com/results/3216363
Comment 4 WebKit Commit Bot 2010-06-13 00:42:15 PDT 
Comment on attachment 58539 [details]
Patch

Rejecting patch 58539 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1
Last 500 characters of output:
html/HTML5DocumentParser.h
patching file WebCore/html/HTML5TreeBuilder.cpp
patching file WebCore/html/HTML5TreeBuilder.h
patching file WebCore/html/HTMLDocumentParser.cpp
patching file WebCore/html/HTMLDocumentParser.h
Hunk #1 FAILED at 163.
1 out of 2 hunks FAILED -- saving rejects to file WebCore/html/HTMLDocumentParser.h.rej
patching file WebCore/html/HTMLFormControlElement.cpp
Hunk #1 FAILED at 178.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLFormControlElement.cpp.rej

Full output: http://webkit-commit-queue.appspot.com/results/3272030
Comment 5 Eric Seidel (no email) 2010-06-13 18:13:28 PDT 
Created attachment 58610 [details]
Patch for landing
Comment 6 Eric Seidel (no email) 2010-06-13 21:01:19 PDT 
Created attachment 58618 [details]
Patch for landing
Comment 7 Adam Barth 2010-06-13 21:48:51 PDT 
Comment on attachment 58618 [details]
Patch for landing

Clearing flags on attachment: 58618

Committed r61106: <http://trac.webkit.org/changeset/61106>
Comment 8 Adam Barth 2010-06-13 21:48:58 PDT 
All reviewed patches have been landed.  Closing bug.