Bug 40508 - Rename the last few *Tokenizer classes (which don't have their own files) to *DocumentParser
Summary: Rename the last few *Tokenizer classes (which don't have their own files) to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-11 17:19 PDT by Eric Seidel (no email)
Modified: 2010-06-12 23:21 PDT (History)
6 users (show)

See Also:


Attachments
Patch (16.65 KB, patch)
2010-06-11 17:21 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-06-11 17:19:42 PDT
Rename the last few *Tokenizer classes (which don't have their own files) to *DocumentParser
Comment 1 Eric Seidel (no email) 2010-06-11 17:21:49 PDT
Created attachment 58530 [details]
Patch
Comment 2 Adam Barth 2010-06-11 17:22:35 PDT
Comment on attachment 58530 [details]
Patch

k
Comment 3 WebKit Commit Bot 2010-06-12 03:44:30 PDT
Comment on attachment 58530 [details]
Patch

Rejecting patch 58530 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1
Last 500 characters of output:
ment.h
Hunk #1 FAILED at 49.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLViewSourceDocument.h.rej
patching file WebCore/loader/FTPDirectoryDocument.cpp
Hunk #1 FAILED at 48.
Hunk #2 FAILED at 94.
2 out of 10 hunks FAILED -- saving rejects to file WebCore/loader/FTPDirectoryDocument.cpp.rej
patching file WebCore/loader/MediaDocument.cpp
patching file WebCore/loader/PluginDocument.cpp
patching file WebCore/loader/SinkDocument.cpp
patching file WebCore/loader/TextDocument.cpp

Full output: http://webkit-commit-queue.appspot.com/results/3191260
Comment 4 WebKit Commit Bot 2010-06-12 22:36:33 PDT
Comment on attachment 58530 [details]
Patch

Clearing flags on attachment: 58530

Committed r61081: <http://trac.webkit.org/changeset/61081>
Comment 5 WebKit Commit Bot 2010-06-12 22:36:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-06-12 22:55:37 PDT
http://trac.webkit.org/changeset/61081 might have broken GTK Linux 64-bit Release
Comment 7 Eric Seidel (no email) 2010-06-12 23:21:02 PDT
I don't see how this rename would cause one test on one gtk bot to start crashing.  We can always try rolling it out of course.