WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
40508
Rename the last few *Tokenizer classes (which don't have their own files) to *DocumentParser
https://bugs.webkit.org/show_bug.cgi?id=40508
Summary
Rename the last few *Tokenizer classes (which don't have their own files) to ...
Eric Seidel (no email)
Reported
2010-06-11 17:19:42 PDT
Rename the last few *Tokenizer classes (which don't have their own files) to *DocumentParser
Attachments
Patch
(16.65 KB, patch)
2010-06-11 17:21 PDT
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2010-06-11 17:21:49 PDT
Created
attachment 58530
[details]
Patch
Adam Barth
Comment 2
2010-06-11 17:22:35 PDT
Comment on
attachment 58530
[details]
Patch k
WebKit Commit Bot
Comment 3
2010-06-12 03:44:30 PDT
Comment on
attachment 58530
[details]
Patch Rejecting patch 58530 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Last 500 characters of output: ment.h Hunk #1 FAILED at 49. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLViewSourceDocument.h.rej patching file WebCore/loader/FTPDirectoryDocument.cpp Hunk #1 FAILED at 48. Hunk #2 FAILED at 94. 2 out of 10 hunks FAILED -- saving rejects to file WebCore/loader/FTPDirectoryDocument.cpp.rej patching file WebCore/loader/MediaDocument.cpp patching file WebCore/loader/PluginDocument.cpp patching file WebCore/loader/SinkDocument.cpp patching file WebCore/loader/TextDocument.cpp Full output:
http://webkit-commit-queue.appspot.com/results/3191260
WebKit Commit Bot
Comment 4
2010-06-12 22:36:33 PDT
Comment on
attachment 58530
[details]
Patch Clearing flags on attachment: 58530 Committed
r61081
: <
http://trac.webkit.org/changeset/61081
>
WebKit Commit Bot
Comment 5
2010-06-12 22:36:40 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6
2010-06-12 22:55:37 PDT
http://trac.webkit.org/changeset/61081
might have broken GTK Linux 64-bit Release
Eric Seidel (no email)
Comment 7
2010-06-12 23:21:02 PDT
I don't see how this rename would cause one test on one gtk bot to start crashing. We can always try rolling it out of course.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug