Bug 40507 - Rename the rest of the *Tokenizer classes to *DocumentParser
Summary: Rename the rest of the *Tokenizer classes to *DocumentParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 40491
  Show dependency treegraph
 
Reported: 2010-06-11 16:49 PDT by Eric Seidel (no email)
Modified: 2010-06-12 19:17 PDT (History)
2 users (show)

See Also:


Attachments
Patch (170.07 KB, patch)
2010-06-11 16:58 PDT, Eric Seidel (no email)
abarth: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-06-11 16:49:54 PDT
Rename the rest of the *Tokenizer classes to *DocumentParser
Comment 1 Eric Seidel (no email) 2010-06-11 16:58:10 PDT
Created attachment 58529 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-11 17:00:21 PDT
This is mostly looking for a rubber stamp.  The changes are much smaller than the diff-size would have you believe.
Comment 3 Adam Barth 2010-06-11 17:16:33 PDT
Comment on attachment 58529 [details]
Patch

Ok...
Comment 4 WebKit Commit Bot 2010-06-12 03:14:42 PDT
Comment on attachment 58529 [details]
Patch

Rejecting patch 58529 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 58529, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
date_status
    return NetworkTransaction().run(lambda: self._post_status_to_server(queue_name, status, patch, results_file))
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/net/networktransaction.py", line 56, in run
    self._check_for_timeout()
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/net/networktransaction.py", line 63, in _check_for_timeout
    raise NetworkTimeout()
webkitpy.common.net.networktransaction.NetworkTimeout
Comment 5 Eric Seidel (no email) 2010-06-12 18:04:28 PDT
That generally mean there was a build error.  I'll check locally.
Comment 6 Eric Seidel (no email) 2010-06-12 18:41:57 PDT
Yes, the build failed due to another patch landing before this one and adding new methods to HTML5Tokenizer which didn't get properly renamed.  Landing by hand now.
Comment 7 Eric Seidel (no email) 2010-06-12 19:17:05 PDT
Committed r61073: <http://trac.webkit.org/changeset/61073>