do-webcore-rename should have a --verbose option

[Eric Seidel (no email)]

do-webcore-rename should have a --verbose option

[Eric Seidel (no email)]

Created attachment 58506 [details]
Patch

[Eric Seidel (no email)]

Created attachment 58509 [details]
Fixed --help support per wms's comment

[Eric Seidel (no email)]

Comment on attachment 58509 [details]
Fixed --help support per wms's comment

I keep forgetting to pass --request-commit.  sigh.

[Daniel Bates]

Comment on attachment 58509 [details]
Fixed --help support per wms's comment

> -    if ($file =~ /^\../) {
> +    # Ignore excluded and hidden files/directories.
> +    if ($directoriesToIgnore{$file} or $file =~ /^\../ or $file =~ /^ChangeLog/) {
> +        print "Ignoring $File::Find::name\n" if $verbose;
>          $File::Find::prune = 1;

As far as I can tell, $File::Find::prune only makes sense with respects to directories (to prevent descending into a directory), but I don't anticipate any issues with setting this on a file, say the ChangeLog files.

>          return;

r=me.

[Eric Seidel (no email)]

Comment on attachment 58509 [details]
Fixed --help support per wms's comment

Yup the "extra" prune causes no harm.

[WebKit Commit Bot]

Comment on attachment 58509 [details]
Fixed --help support per wms's comment

Clearing flags on attachment: 58509

Committed r61080: <http://trac.webkit.org/changeset/61080>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.