Bug 40476 – [Qt] Support custom open() verbs/methods in XMLHttpRequest

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Andreas Kling]

For Qt 4.7 we can implement this by falling back to QNetworkAccessManager::CustomOperation for any verb that's not specifically supported by QNAM.

[Andreas Kling]

It should be noted that current QtWebKit hangs completely when attempting to use an unknown verb with XHR.

[Andreas Kling]

Created attachment 58475 [details]
Proposed patch

[Kenneth Rohde Christiansen]

Comment on attachment 58475 [details]
Proposed patch

Are there any security implications of this?

[Andreas Kling]

(In reply to comment #3)
> (From update of attachment 58475 [details])
> Are there any security implications of this?

The verb is sanitized in XMLHttpRequest::open() (WebCore/xml/XMLHttpRequest.cpp)

AFAICT the Mac port does the same thing as this patch (passes the method argument verbatim.)

[Eric Seidel (no email)]

Comment on attachment 58475 [details]
Proposed patch

This needs a layout test.  It should be possible to test this with an http test.

[Dinu Jacob]

(In reply to comment #5)
> (From update of attachment 58475 [details])
> This needs a layout test.  It should be possible to test this with an http test.

Layout test with custom verb already exists under xmlhttprequest. For example: methods.html uses the verbs "WKFOOBAR", "HEAD", "SEARCH" etc

[Dinu Jacob]

(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 58475 [details] [details])
> > This needs a layout test.  It should be possible to test this with an http test.
> 
> Layout test with custom verb already exists under xmlhttprequest. For example: methods.html uses the verbs "WKFOOBAR", "HEAD", "SEARCH" etc

Test File: LayoutTests/http/tests/xmlhttprequest/methods.html

[Andreas Kling]

Comment on attachment 58475 [details]
Proposed patch

Resetting r? since this is covered by existing (skipped) tests. They will be unskipped once the Qt buildbot is updated to Qt 4.7.

[Kenneth Rohde Christiansen]

Comment on attachment 58475 [details]
Proposed patch

the ChangeLog doesn't explain why this is a good thing.

[Andreas Kling]

Created attachment 70978 [details]
Proposed patch v2

Updated patch with more elaborate ChangeLog.

[Andreas Kling]

Thanks for the review Kenneth :)
There's a missing 4.7 guard in httpMethod(), I'll land with that tomorrow, gotta run.

[Early Warning System Bot]

Attachment 70978 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4456062

[Andreas Kling]

Committed r69946: <http://trac.webkit.org/changeset/69946>