Bug 40469 - Nighly build script broken
Summary: Nighly build script broken
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-11 03:55 PDT by Philippe Normand
Modified: 2010-06-14 23:48 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-06-11 03:55:13 PDT
Since http://trac.webkit.org/changeset/44111 the WebKitLauncher assumes the frameworks of the bundle are in Frameworks/$version/... but the build-launcher-app script copies them to Resources/.

Moreover build-launcher-app mentions Drosera which seems to be attic.

Please commit the latest version of build-launcher-app, I know someone has it because the "official" nighlies builds work.
Comment 1 Mark Rowe (bdash) 2010-06-11 14:41:20 PDT
The version of this script that is used when packaging the nightly builds may not be particularly useful to you as it requires that the frameworks are built multiple times (one for each support OS version).  When I find some time I’ll dig it up and see what sort of shape it is in.

I should also mention that I’m not particularly keen on having people distributing things that look to be identical to WebKit nightlies.  Builds that can be mistaken for the WebKit nightlies make investigating bug reports incredibly difficult as we would then have to first determine how the build was created, which versions of the code it uses, whether it was built correctly, etc.
Comment 2 Philippe Normand 2010-06-14 23:48:46 PDT
(In reply to comment #1)
> The version of this script that is used when packaging the nightly builds may not be particularly useful to you as it requires that the frameworks are built multiple times (one for each support OS version).  When I find some time I’ll dig it up and see what sort of shape it is in.
> 

Thanks.

> I should also mention that I’m not particularly keen on having people distributing things that look to be identical to WebKit nightlies.  Builds that can be mistaken for the WebKit nightlies make investigating bug reports incredibly difficult as we would then have to first determine how the build was created, which versions of the code it uses, whether it was built correctly, etc.

Well that can be solved by allowing to edit and add informations in the "about" menu of the snapshot no? There's the SVN revision already. It would be nice to allow adding extra text so that if the user finds a bug and wants to report it he could provide those informations.