Bug 40468 - Bindings scripts sanitization.
Summary: Bindings scripts sanitization.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-11 02:55 PDT by Ilya Tikhonovsky
Modified: 2010-06-14 04:00 PDT (History)
9 users (show)

See Also:

Attachments
[patch] initial version. (7.53 KB, patch)
2010-06-11 03:04 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2010-06-11 02:55:17 PDT 
Perl scripts for bindings don't use strict rules.
As result some errors in the code were not detected.
Comment 1 Ilya Tikhonovsky 2010-06-11 03:04:20 PDT 
Created attachment 58459 [details]
[patch] initial version.
Comment 2 Eric Seidel (no email) 2010-06-11 08:20:44 PDT 
Comment on attachment 58459 [details]
[patch] initial version.

Yay!  Definitely better than before.
Comment 3 WebKit Commit Bot 2010-06-11 09:04:56 PDT 
Comment on attachment 58459 [details]
[patch] initial version.

Clearing flags on attachment: 58459

Committed r61022: <http://trac.webkit.org/changeset/61022>
Comment 4 WebKit Commit Bot 2010-06-11 09:05:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2010-06-12 17:43:31 PDT 
> As result some errors in the code were not detected.

If these errors affected generated code, then this patch should have had regression tests.
Comment 6 Ilya Tikhonovsky 2010-06-14 04:00:45 PDT 
(In reply to comment #5)
> > As result some errors in the code were not detected.
> 
> If these errors affected generated code, then this patch should have had regression tests.

All the builds are the regression tests for these scripts.
The real error has effect only for debug logging.