RESOLVED FIXED 40468
Bindings scripts sanitization. 
https://bugs.webkit.org/show_bug.cgi?id=40468
Summary Bindings scripts sanitization.
Ilya Tikhonovsky
Reported Friday, June 11, 2010 10:55:17 AM UTC
Perl scripts for bindings don't use strict rules. As result some errors in the code were not detected.
Attachments
[patch] initial version. (7.53 KB, patch)
2010-06-11 03:04 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 Friday, June 11, 2010 11:04:20 AM UTC
Created attachment 58459 [details] [patch] initial version.
Eric Seidel (no email)
Comment 2 Friday, June 11, 2010 4:20:44 PM UTC
Comment on attachment 58459 [details] [patch] initial version. Yay! Definitely better than before.
WebKit Commit Bot
Comment 3 Friday, June 11, 2010 5:04:56 PM UTC
Comment on attachment 58459 [details] [patch] initial version. Clearing flags on attachment: 58459 Committed r61022: <http://trac.webkit.org/changeset/61022>
WebKit Commit Bot
Comment 4 Friday, June 11, 2010 5:05:04 PM UTC
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 Sunday, June 13, 2010 1:43:31 AM UTC
> As result some errors in the code were not detected. If these errors affected generated code, then this patch should have had regression tests.
Ilya Tikhonovsky
Comment 6 Monday, June 14, 2010 12:00:45 PM UTC
(In reply to comment #5) > > As result some errors in the code were not detected. > > If these errors affected generated code, then this patch should have had regression tests. All the builds are the regression tests for these scripts. The real error has effect only for debug logging.
Note You need to log in before you can comment on or make changes to this bug.