Bug 40464 - [chromium] Clicking a login input field should open a popup with the saved logins
Summary: [chromium] Clicking a login input field should open a popup with the saved lo...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-11 00:11 PDT by Jay Civelli
Modified: 2010-08-11 11:04 PDT (History)
5 users (show)

See Also:


Attachments
First version (6.34 KB, patch)
2010-06-11 00:50 PDT, Jay Civelli
tkent: review-
Details | Formatted Diff | Diff
Addressing tkent's comment (6.34 KB, patch)
2010-06-13 23:02 PDT, Jay Civelli
tkent: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Civelli 2010-06-11 00:11:42 PDT
In order to make Chromium password autofill easier to use for users that have  multiple accounts for a same site, clicking an input field should show the list of saved logins for that site.
Comment 1 Jay Civelli 2010-06-11 00:50:10 PDT
Created attachment 58452 [details]
First version
Comment 2 WebKit Review Bot 2010-06-11 10:24:38 PDT
Attachment 58452 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/src/DOMUtilitiesPrivate.h:49:  Use 0 instead of NULL.  [readability/null] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dirk Pranke 2010-06-11 15:37:09 PDT
Comment on attachment 58452 [details]
First version

I'm not a reviewer, and I'm not an expert on this code, but this looks good to me.
Comment 4 Kent Tamura 2010-06-12 19:50:03 PDT
Comment on attachment 58452 [details]
First version

WebKit/chromium/public/WebPasswordAutocompleteListener.h:52
 +      virtual bool showSuggestionPopup(const string16& value) = 0;
We should use WebString instead of string16 for WebKit API.
Comment 5 Jay Civelli 2010-06-13 23:02:02 PDT
Created attachment 58623 [details]
Addressing tkent's comment
Comment 6 WebKit Review Bot 2010-06-13 23:03:56 PDT
Attachment 58623 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/src/DOMUtilitiesPrivate.h:49:  Use 0 instead of NULL.  [readability/null] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Kent Tamura 2010-06-13 23:28:45 PDT
Comment on attachment 58623 [details]
Addressing tkent's comment

Please set commit-queue=? when Chromium side is ready.
Comment 8 Adam Barth 2010-08-10 22:07:49 PDT
This has been sitting in pending-commit for a while.  Is the Chromium side ready?
Comment 9 Jay Civelli 2010-08-11 11:04:38 PDT
We are moving the password and form autofill code to Chromium so this bug and patch are now obsolete.