In order to make Chromium password autofill easier to use for users that have multiple accounts for a same site, clicking an input field should show the list of saved logins for that site.
Created attachment 58452 [details] First version
Attachment 58452 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/chromium/src/DOMUtilitiesPrivate.h:49: Use 0 instead of NULL. [readability/null] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 58452 [details] First version I'm not a reviewer, and I'm not an expert on this code, but this looks good to me.
Comment on attachment 58452 [details] First version WebKit/chromium/public/WebPasswordAutocompleteListener.h:52 + virtual bool showSuggestionPopup(const string16& value) = 0; We should use WebString instead of string16 for WebKit API.
Created attachment 58623 [details] Addressing tkent's comment
Attachment 58623 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/chromium/src/DOMUtilitiesPrivate.h:49: Use 0 instead of NULL. [readability/null] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 58623 [details] Addressing tkent's comment Please set commit-queue=? when Chromium side is ready.
This has been sitting in pending-commit for a while. Is the Chromium side ready?
We are moving the password and form autofill code to Chromium so this bug and patch are now obsolete.