Bug 40444 - upload all patches that lack in-rietveld to rietveld
Summary: upload all patches that lack in-rietveld to rietveld
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-10 14:20 PDT by Ojan Vafai
Modified: 2010-06-11 16:55 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.07 KB, patch)
2010-06-10 14:21 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Exclude obsolete patches (4.36 KB, patch)
2010-06-10 15:09 PDT, Ojan Vafai 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-06-10 14:20:04 PDT 
upload all patches that lack in-rietveld to rietveld
Comment 1 Ojan Vafai 2010-06-10 14:21:26 PDT 
Created attachment 58411 [details]
Patch
Comment 2 Adam Barth 2010-06-10 14:54:50 PDT 
Comment on attachment 58411 [details]
Patch

Have you looked to see how many patches this is?  Could be a lot...
Comment 3 Ojan Vafai 2010-06-10 15:09:25 PDT 
Created attachment 58417 [details]
Exclude obsolete patches
Comment 4 Eric Seidel (no email) 2010-06-11 12:03:49 PDT 
Comment on attachment 58417 [details]
Exclude obsolete patches

Please run this manually from your machine before changing the queue run on adams. :)  Honestly, you should just run the rietvled queue on your machine so you can test edits like this. :)
Comment 5 Ojan Vafai 2010-06-11 12:22:45 PDT 
I've been running this on my machine. There were 1200 patches. There are now ~300. It'll be caught up in ~3 hours.
Comment 6 Ojan Vafai 2010-06-11 16:21:47 PDT 
The queue is now caught up. Does this patch seem OK?
Comment 7 Eric Seidel (no email) 2010-06-11 16:47:21 PDT 
I feel for poor bugs.webkit.org. :p
Comment 8 Eric Seidel (no email) 2010-06-11 16:48:21 PDT 
Comment on attachment 58417 [details]
Exclude obsolete patches

OK.  Seems like we shouldn't ever bother to set in-reitveld=? now then. :)
Comment 9 Ojan Vafai 2010-06-11 16:55:17 PDT 
Committed r61047: <http://trac.webkit.org/changeset/61047>