40436 – fix handle_script_error in rietveld upload queue and add testing for handle_script_error

Bug 40436 - fix handle_script_error in rietveld upload queue and add testing for handle_script_error

Summary: fix handle_script_error in rietveld upload queue and add testing for handle_s...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Other OS X 10.5

Importance:	P2 Normal
Assignee:	Ojan Vafai

URL:
Keywords:

Depends on:
Blocks:

Reported:	2010-06-10 11:47 PDT by Ojan Vafai
Modified:	2010-06-10 15:37 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
Patch (17.10 KB, patch) 2010-06-10 11:48 PDT, Ojan Vafai	abarth: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ojan Vafai 2010-06-10 11:47:46 PDT

fix handle_script_error in rietveld upload queue and add testing for handle_script_error

Comment 1 Ojan Vafai 2010-06-10 11:48:23 PDT

Created attachment 58397 [details]
Patch

Comment 2 Adam Barth 2010-06-10 14:20:06 PDT

Comment on attachment 58397 [details]
Patch

Looks good.  Thanks.

Comment 3 Ojan Vafai 2010-06-10 14:55:46 PDT

Committed r60976: <http://trac.webkit.org/changeset/60976>

Comment 4 WebKit Review Bot 2010-06-10 15:37:42 PDT

http://trac.webkit.org/changeset/60976 might have broken SnowLeopard Intel Release (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/60976
http://trac.webkit.org/changeset/60977
http://trac.webkit.org/changeset/60978
http://trac.webkit.org/changeset/60974
http://trac.webkit.org/changeset/60975