Bug 40424 – Implement more of IndexedDB's Indexes and ObjectStores

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jeremy Orlow]

Implement more of IndexedDB's Indexes and ObjectStores

[Jeremy Orlow]

Created attachment 58374 [details]
Patch

[Andrei Popescu]

Looks good, one comment below:

> PassRefPtr<IDBObjectStoreRequest> IDBDatabaseRequest::objectStore(const String& name, unsigned short mode)
> {
>     RefPtr<IDBObjectStore> objectStore = m_database->objectStore(name, mode);
>     ASSERT(objectStore); // FIXME: If this is null, we should raise a NOT_FOUND_ERR.
>     return IDBObjectStoreRequest::create(objectStore.release());
> }

The spec says about this:

// Simple shorthand for transaction([name], mode).objectStore(name);
// Returns object immediately.

So simply returning an object is incorrect, we should also call transaction(). Add a FIXME?

Furthermore, why not raise NOT_FOUND_ERR if an object store with that name doesn't exist rather than the ASSERT + FIXME? It's just a one-liner, right? Or am I missing something?

[Jeremy Orlow]

(In reply to comment #2)
> Looks good, one comment below:
> 
> > PassRefPtr<IDBObjectStoreRequest> IDBDatabaseRequest::objectStore(const String& name, unsigned short mode)
> > {
> >     RefPtr<IDBObjectStore> objectStore = m_database->objectStore(name, mode);
> >     ASSERT(objectStore); // FIXME: If this is null, we should raise a NOT_FOUND_ERR.
> >     return IDBObjectStoreRequest::create(objectStore.release());
> > }
> 
> The spec says about this:
> 
> // Simple shorthand for transaction([name], mode).objectStore(name);
> // Returns object immediately.
> 
> So simply returning an object is incorrect, we should also call transaction(). Add a FIXME?

k.
 
> Furthermore, why not raise NOT_FOUND_ERR if an object store with that name doesn't exist rather than the ASSERT + FIXME? It's just a one-liner, right? Or am I missing something?

I need to add a bunch of code to support IDBDatabaseExceptions.  Best left to its own patch, I think.

[Jeremy Orlow]

Ping.  Given that Andrei has done an unofficial review of the meat (he's working with me on implementing it), it should be a really easy r+

[Jeremy Orlow]

Committed r61015: <http://trac.webkit.org/changeset/61015>