Bug 40423 - Fix invalid access to non-static data member warning in JITPropertyAccess32_64 on ARM
Summary: Fix invalid access to non-static data member warning in JITPropertyAccess32_6...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-10 06:30 PDT by Gabor Loki
Modified: 2010-06-15 02:14 PDT (History)
2 users (show)

See Also:


Attachments
Fix invalid access to non-static data member warning in JITPropertyAccess32_64 (2.22 KB, patch)
2010-06-10 06:32 PDT, Gabor Loki
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2010-06-10 06:30:19 PDT
The offsetof(struct JITStackFrame, args[2]) expression cause an invalid access to non-static data member 'JSC::JITStackFrame::args' of NULL object warning.
Using OBJECT_OFFSETOF macro instead of objectof one will fix this issue.
Comment 1 Gabor Loki 2010-06-10 06:32:40 PDT
Created attachment 58372 [details]
Fix invalid access to non-static data member warning in JITPropertyAccess32_64
Comment 2 Eric Seidel (no email) 2010-06-12 18:52:04 PDT
Comment on attachment 58372 [details]
Fix invalid access to non-static data member warning in JITPropertyAccess32_64

rs=me.
Comment 3 Eric Seidel (no email) 2010-06-12 18:52:19 PDT
Is this testable?
Comment 4 Gabor Loki 2010-06-15 02:07:54 PDT
What do you mean? With a layout test? It is already tested in jscore tests. Just turn on WTF_USE_JSVALUE32_64 if it is not enabled by default (like on ARM).
Comment 5 Gabor Loki 2010-06-15 02:14:43 PDT
Committed revision 61180.