Bug 40409 – Web Inspector: [REGRESSION] Tab complete in a command line jumps on next value

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Nikita Vasilyev]

How to reproduce the bug:
1. Type "document.get" in the command line. You should see document.get<CSSCanvasContext> (<> is an auto-suggestion)
2. Press Tab

Expected:
"document.get[CSSCanvasContext]" ([] is a selected text)

Actual:
"document.get[ElementById]"

Screencast: http://screenr.com/9gK

[Pavel Feldman]

https://bugs.webkit.org/show_bug.cgi?id=38753 is a primary suspect.

[Nikita Vasilyev]

Created attachment 58347 [details]
Then complete using a tab key, select very first value, not a second.

[Pavel Feldman]

Comment on attachment 58347 [details]
Then complete using a tab key, select very first value, not a second.

Thanks for fixing this. I small nit about the changelog entry and you are good to land!

WebCore/ChangeLog:5
 +          Web Inspector: Then complete using a tab key, select very first value, not a second.
When completing using ...

Please re-attach new path and I'll mark it as r+,cq+!

[Nikita Vasilyev]

Created attachment 58350 [details]
When completing using a tab key, select very first value, not a second.

My terrible grammar fixed.

[Ilya Tikhonovsky]

It was a conscious decision as far as we have auto-suggestion mechanic.
If the first suggestion is not suitable for you it is possible to get the next by tab.
In the other case you can complete suggested variant by arrow.

Your scenario is fine if we have no auto-suggestions mechanics.

[Nikita Vasilyev]

(In reply to comment #5)
It makes sense, but:

1) Tab is easier to press than right arrow. I do it with my left little finger without leaving the pointer finger from F key.

2) I've never seen applications which behaves like this. Xcode have a similar gray auto-suggestion, but by pressing Tab you're completing a current suggestion, not the next one.

[WebKit Commit Bot]

Comment on attachment 58350 [details]
When completing using a tab key, select very first value, not a second.

Rejecting patch 58350 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Last 500 characters of output:
ing Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found
Testing 19073 test cases.
svg/dom/SVGScriptElement/script-set-href.svg -> failed

Exiting early after 1 failures. 16747 tests run.
362.26s total testing time

16746 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
15 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/3217143

[Joseph Pecoraro]

That commit queue failure was unrelated. If no-body gets to this tomorrow I can try to land it manually (my tree is outdated on this machine, so I'll be updating and building overnight).

Feel free to beat me to it!

Otherwise, does re-flipping the cq+ flag make the commit queue try again? I'll try that.

[WebKit Commit Bot]

Comment on attachment 58350 [details]
When completing using a tab key, select very first value, not a second.

Clearing flags on attachment: 58350

Committed r60995: <http://trac.webkit.org/changeset/60995>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.