Bug 40402 - [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
Summary: [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-09 23:02 PDT by Kent Tamura
Modified: 2010-06-12 05:44 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.33 KB, patch)
2010-06-10 00:18 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch (rev.2) (4.40 KB, patch)
2010-06-10 00:39 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-06-09 23:02:04 PDT
On Mac, "new-run-webkit-test --chromium --use-drt" doesn't work in Chromium tree.
Linux and Windows seem to have the same problem.

_build_path() in webkitpy/layout_test/port/chromium_*.py  have a problem.
Comment 1 Kent Tamura 2010-06-09 23:07:49 PDT
NRWT tries to use
  src/third_party/WebKit/WebKit/chromium/xcodebuild/Debug/DumpRenderTree.app
instead of
  src/xcodebuild/Debug/DumpRenderTree.app

We need to use path_from_chromium_base() even if --use-drt is specified.
Comment 2 Tony Chang 2010-06-09 23:11:09 PDT
I think it would be ideal if we first tried src/third_party/WebKit/WebKit/chromium/xcodebuild/Debug/DumpRenderTree.app then fell back to src/xcodebuild/Debug/DumpRenderTree.app.  For example, if I only have a chromium checkout, I sometimes use build-webkit --chromium in src/third_party/WebKit/ to make and test changes.
Comment 3 Kent Tamura 2010-06-10 00:18:14 PDT
Created attachment 58337 [details]
Patch
Comment 4 Tony Chang 2010-06-10 00:37:50 PDT
LGTM (but I am not a reviewer)
Comment 5 Kent Tamura 2010-06-10 00:39:25 PDT
Created attachment 58340 [details]
Patch (rev.2)
Comment 6 Dimitri Glazkov (Google) 2010-06-11 10:26:14 PDT
Comment on attachment 58340 [details]
Patch (rev.2)

ok.
Comment 7 Kent Tamura 2010-06-12 05:44:14 PDT
Comment on attachment 58340 [details]
Patch (rev.2)

Clearing flags on attachment: 58340

Committed r61061: <http://trac.webkit.org/changeset/61061>
Comment 8 Kent Tamura 2010-06-12 05:44:25 PDT
All reviewed patches have been landed.  Closing bug.