Bug 40400 – Refactoring: Simple shadow elements should be factored out .

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Hajime Morrita]

There are several simple shadow element classes defined under rendering/*.cpp.
And some of them (ProgressValueElement, ShadowInputElement, SliderThumbElement) are 
pretty simple, and have similar definitions.
I'm going to another one for Bug 40280, so we should factored out the definition from them,
instead of making another copy.

[Hajime Morrita]

Created attachment 58334 [details]
patch v0

[WebKit Review Bot]

Attachment 58334 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/RenderSlider.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/rendering/ShadowElement.cpp:22:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
WebCore/rendering/ShadowElement.h:66:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 3 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Hajime Morrita]

Created attachment 58335 [details]
patch v1; fixed style violation

[Kent Tamura]

Comment on attachment 58335 [details]
patch v1; fixed style violation

This is a good refactoring.

Please check if we can share code with rendering/TextControllInnerElements.{cpp,h} too.


WebCore/WebCore.xcodeproj/project.pbxproj:21765
 +  				A7E5D1D111C0AE25000A338E /* ShadowElement.cpp in Sources */,
We should sort lists in project.pbxproj.
As you saw, the current pbxproj is not sorted correctly.  So you might want to run WebKitTools/Scripts/sort-Xcode-project-file before this change.

[Hajime Morrita]

Created attachment 58339 [details]
patch v2; sorted file order on project file

[Hajime Morrita]

Hi Kent-san, thank you for reviewing!

> Please check if we can share code with rendering/TextControllInnerElements.{cpp,h} too.
Their lifecycle model is different a bit;
i.e. are created without parent node, then attached the Node after some operation.
Although it might be possible to adopt ShadowElement to them,
I would be better to keep as is for ShadowElement simplicity.

> 
> WebCore/WebCore.xcodeproj/project.pbxproj:21765
>  +                  A7E5D1D111C0AE25000A338E /* ShadowElement.cpp in Sources */,
> We should sort lists in project.pbxproj.
Sorted out with the script.

[Kent Tamura]

Comment on attachment 58339 [details]
patch v2; sorted file order on project file

OK.
Please make sure all of layout tests pass on Mac before committing.

[Hajime Morrita]

Committed r60951: <http://trac.webkit.org/changeset/60951>