Bug 40397 – [Chromium] Add the ability to specify a separator in AutoFillPopupMenuChromium

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[James Hawkins]

Will upload patch .

[James Hawkins]

Created attachment 58316 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 58316 [details]
Patch

WebKit/chromium/public/WebViewClient.h:295
 +      virtual void didAcceptAutoFillSuggestion(const WebNode&,
perhaps you should keep the old form of this method around and make
the default implementation of this method call that one?  that way
you won't require a two-sided patch landing to avoid regressing chrome?

WebKit/chromium/src/AutoFillPopupMenuClient.cpp:63
 +        return suggestion;
nit: indent by 4 spaces

looks ok otherwise.

[James Hawkins]

Created attachment 58387 [details]
Patch

[James Hawkins]

(In reply to comment #2)
> (From update of attachment 58316 [details])
> WebKit/chromium/public/WebViewClient.h:295
>  +      virtual void didAcceptAutoFillSuggestion(const WebNode&,
> perhaps you should keep the old form of this method around and make
> the default implementation of this method call that one?  that way
> you won't require a two-sided patch landing to avoid regressing chrome?
> 

I'll commit the chromium side first, which adds the new method and deprecates the old, obviating the need for the old method in the API.

> WebKit/chromium/src/AutoFillPopupMenuClient.cpp:63
>  +        return suggestion;
> nit: indent by 4 spaces
> 

Done.

[James Hawkins]

Committed r60985: <http://trac.webkit.org/changeset/60985>

[WebKit Review Bot]

http://trac.webkit.org/changeset/60985 might have broken Chromium Mac Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/60984
http://trac.webkit.org/changeset/60985