RESOLVED INVALID40395
Image Resizer Patch 2: Adding basic resize functionality 
https://bugs.webkit.org/show_bug.cgi?id=40395
Summary Image Resizer Patch 2: Adding basic resize functionality
Sterling Swigart
Reported 2010-06-09 17:19:59 PDT
Created attachment 58313 [details] Patch 2 See Summary.
Attachments
Patch 2 (10.91 KB, patch)
2010-06-09 17:19 PDT, Sterling Swigart 		sswigart: review-
sswigart: commit-queue-
DetailsFormatted DiffDiff
Waiting on patch 1, fixed a couple issues (13.36 KB, patch)
2010-06-09 18:39 PDT, Sterling Swigart 		sswigart: commit-queue-
DetailsFormatted DiffDiff
Testing platform builds of ImageBuffer (13.36 KB, patch)
2010-06-11 08:06 PDT, Sterling Swigart 		no flags
DetailsFormatted DiffDiff
Patch 2 (13.38 KB, patch)
2010-06-11 08:24 PDT, Sterling Swigart 		no flags
DetailsFormatted DiffDiff
Patch 2 (13.42 KB, patch)
2010-06-11 08:59 PDT, Sterling Swigart 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sterling Swigart
Comment 1 2010-06-09 17:29:37 PDT
Oops, patch 1 has not been committed yet. I will resubmit the attachment after it is so that the files being patched exist...
David Levin
Comment 2 2010-06-09 17:39:16 PDT
A test comment to see if I get email on this bug.
Sterling Swigart
Comment 3 2010-06-09 18:39:02 PDT
Created attachment 58321 [details] Waiting on patch 1, fixed a couple issues
Sterling Swigart
Comment 4 2010-06-11 08:06:13 PDT
Created attachment 58474 [details] Testing platform builds of ImageBuffer
WebKit Review Bot
Comment 5 2010-06-11 08:08:23 PDT
Attachment 58474 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/html/ImageResizerThread.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sterling Swigart
Comment 6 2010-06-11 08:24:30 PDT
Created attachment 58478 [details] Patch 2
WebKit Review Bot
Comment 7 2010-06-11 08:26:42 PDT
Attachment 58478 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/html/ImageResizerThread.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sterling Swigart
Comment 8 2010-06-11 08:59:05 PDT
Created attachment 58480 [details] Patch 2
Sterling Swigart
Comment 9 2010-06-11 13:39:32 PDT
I am going to expose the function to javascript instead for patch 2. This bug will not be used in the future.
Note You need to log in before you can comment on or make changes to this bug.