Bug 40395 - Image Resizer Patch 2: Adding basic resize functionality
Summary: Image Resizer Patch 2: Adding basic resize functionality
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-09 17:19 PDT by Sterling Swigart
Modified: 2010-06-11 13:53 PDT (History)
3 users (show)

See Also:

Attachments
Patch 2 (10.91 KB, patch)
2010-06-09 17:19 PDT, Sterling Swigart 		sswigart: review-
sswigart: commit-queue-
Details | Formatted Diff | Diff
Waiting on patch 1, fixed a couple issues (13.36 KB, patch)
2010-06-09 18:39 PDT, Sterling Swigart 		sswigart: commit-queue-
Details | Formatted Diff | Diff
Testing platform builds of ImageBuffer (13.36 KB, patch)
2010-06-11 08:06 PDT, Sterling Swigart 		no flags Details | Formatted Diff | Diff
Patch 2 (13.38 KB, patch)
2010-06-11 08:24 PDT, Sterling Swigart 		no flags Details | Formatted Diff | Diff
Patch 2 (13.42 KB, patch)
2010-06-11 08:59 PDT, Sterling Swigart 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sterling Swigart 2010-06-09 17:19:59 PDT 
Created attachment 58313 [details]
Patch 2

See Summary.
Comment 1 Sterling Swigart 2010-06-09 17:29:37 PDT 
Oops, patch 1 has not been committed yet. I will resubmit the attachment after it is so that the files being patched exist...
Comment 2 David Levin 2010-06-09 17:39:16 PDT 
A test comment to see if I get email on this bug.
Comment 3 Sterling Swigart 2010-06-09 18:39:02 PDT 
Created attachment 58321 [details]
Waiting on patch 1, fixed a couple issues
Comment 4 Sterling Swigart 2010-06-11 08:06:13 PDT 
Created attachment 58474 [details]
Testing platform builds of ImageBuffer
Comment 5 WebKit Review Bot 2010-06-11 08:08:23 PDT 
Attachment 58474 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/html/ImageResizerThread.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Sterling Swigart 2010-06-11 08:24:30 PDT 
Created attachment 58478 [details]
Patch 2
Comment 7 WebKit Review Bot 2010-06-11 08:26:42 PDT 
Attachment 58478 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/html/ImageResizerThread.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Sterling Swigart 2010-06-11 08:59:05 PDT 
Created attachment 58480 [details]
Patch 2
Comment 9 Sterling Swigart 2010-06-11 13:39:32 PDT 
I am going to expose the function to javascript instead for patch 2. This bug will not be used in the future.