Bug 40370 - Failing LayoutTests/canvas/philip/tests/2d.shadow.enable.blur.html
Summary: Failing LayoutTests/canvas/philip/tests/2d.shadow.enable.blur.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P3 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-09 11:01 PDT by Chang Shu
Modified: 2010-06-10 09:49 PDT (History)
5 users (show)

See Also:

Attachments
fix patch (17.78 KB, patch)
2010-06-09 12:39 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
fix patch (18.62 KB, patch)
2010-06-09 14:42 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
fix patch (23.30 KB, patch)
2010-06-09 18:12 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2010-06-09 11:01:50 PDT 
The above test case fails on all platforms but works on Firefox.
Comment 1 Chang Shu 2010-06-09 12:39:52 PDT 
Created attachment 58278 [details]
fix patch
Comment 2 WebKit Review Bot 2010-06-09 12:43:11 PDT 
Attachment 58278 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/graphics/wx/GraphicsContextWx.cpp:557:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2010-06-09 13:29:24 PDT 
Attachment 58278 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3179105
Comment 4 WebKit Review Bot 2010-06-09 14:12:49 PDT 
Attachment 58278 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/3183114
Comment 5 Chang Shu 2010-06-09 14:42:45 PDT 
Created attachment 58298 [details]
fix patch
Comment 6 WebKit Review Bot 2010-06-09 15:46:53 PDT 
Attachment 58298 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/3205100
Comment 7 Chang Shu 2010-06-09 18:12:43 PDT 
Created attachment 58318 [details]
fix patch
Comment 8 WebKit Commit Bot 2010-06-10 09:49:23 PDT 
Comment on attachment 58318 [details]
fix patch

Clearing flags on attachment: 58318

Committed r60961: <http://trac.webkit.org/changeset/60961>
Comment 9 WebKit Commit Bot 2010-06-10 09:49:29 PDT 
All reviewed patches have been landed.  Closing bug.